issues: 444916502
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | pull_request | body | performed_via_github_app | repo | type | reactions | draft | state_reason | closed_by | sub_issues_summary | issue_dependencies_summary | pinned_comment | issue_field_values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 444916502 | MDExOlB1bGxSZXF1ZXN0Mjc5NDc1MDIx | 70 | Use i32 everywhere for counters | 2129 | closed | 0 | 0 | 2019-05-16T12:04:02Z | 2019-05-16T12:49:24Z | 2019-05-16T12:48:56Z | MEMBER | mozilla/glean/pulls/70 | We actually should use u32 internally, but: because Kotlin doesn't (yet) have unsigned integers, it's always going to pass us signed values. We also do all the error checking on the Rust side, so we need to receive the signed value to check for negativity and bail out. We still don't do overflow checks though. [Bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1552131) ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly | 160544457 | pull | {"url": "https://api.github.com/repos/mozilla/glean/issues/70/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 0 | {"login": "badboy", "id": 2129, "node_id": "MDQ6VXNlcjIxMjk=", "avatar_url": "https://avatars.githubusercontent.com/u/2129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/badboy", "html_url": "https://github.com/badboy", "followers_url": "https://api.github.com/users/badboy/followers", "following_url": "https://api.github.com/users/badboy/following{/other_user}", "gists_url": "https://api.github.com/users/badboy/gists{/gist_id}", "starred_url": "https://api.github.com/users/badboy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/badboy/subscriptions", "organizations_url": "https://api.github.com/users/badboy/orgs", "repos_url": "https://api.github.com/users/badboy/repos", "events_url": "https://api.github.com/users/badboy/events{/privacy}", "received_events_url": "https://api.github.com/users/badboy/received_events", "type": "User", "user_view_type": "public", "site_admin": false} | [] |
Links from other tables
- 0 rows from issues_id in issues_labels