issues: 446512187

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason pull_request body performed_via_github_app repo type reactions draft state_reason closed_by sub_issues_summary issue_dependencies_summary pinned_comment issue_field_values
446512187 MDExOlB1bGxSZXF1ZXN0MjgwNjk2ODMx 84 Bug 1552850 - Implement shouldRecord on the Kotlin side 2129 closed 0     0 2019-05-21T09:27:58Z 2019-05-23T11:31:31Z 2019-05-22T08:29:36Z MEMBER   mozilla/glean/pulls/84 Posting this because the code part was easy, but I have some hesitations: * The `should_record` check _also_ happens on the Rust side * We do avoid putting any work in the Dispatcher queue with this. * The (Rust-side) check is on the metric and requires access to the glean object, therefore we need to re-implement it for every type * There might be a way of using traits here to implement it just once (we will need to "re-implement" exposing the common metric data though) * I opted for not doing that now (it's a refactoring, not blocking anything and the code duplication so far is simple) * We also need to duplicate code on the Kotlin side, because we need a `*_should_record` function per type. Unfortunately I don't see a way to avoid this (again, duplication here contains no complex logic so for now I'm fine with it) The biggest thing remains the first statement: Do we _need_ the check on the Kotlin side or is Rust-side only actually enough? (Dispatch enqueue cost?) ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly   160544457 pull {"url": "https://api.github.com/repos/mozilla/glean/issues/84/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 0   {"login": "badboy", "id": 2129, "node_id": "MDQ6VXNlcjIxMjk=", "avatar_url": "https://avatars.githubusercontent.com/u/2129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/badboy", "html_url": "https://github.com/badboy", "followers_url": "https://api.github.com/users/badboy/followers", "following_url": "https://api.github.com/users/badboy/following{/other_user}", "gists_url": "https://api.github.com/users/badboy/gists{/gist_id}", "starred_url": "https://api.github.com/users/badboy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/badboy/subscriptions", "organizations_url": "https://api.github.com/users/badboy/orgs", "repos_url": "https://api.github.com/users/badboy/repos", "events_url": "https://api.github.com/users/badboy/events{/privacy}", "received_events_url": "https://api.github.com/users/badboy/received_events", "type": "User", "user_view_type": "public", "site_admin": false}       []

Links from other tables