issues: 446789104

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason pull_request body performed_via_github_app repo type reactions draft state_reason closed_by sub_issues_summary issue_dependencies_summary pinned_comment issue_field_values
446789104 MDExOlB1bGxSZXF1ZXN0MjgwOTE5NzI1 85 Move PingType metadata to the Rust side 38294 closed 0     4 2019-05-21T19:36:27Z 2020-04-14T19:09:34Z 2019-05-28T22:02:16Z CONTRIBUTOR   mozilla/glean/pulls/85 I'm just posting this here for discussion -- either here or in our next meeting if that's more efficient. FFI and Kotlin side not implemented yet. I first considered putting the ping registry on the Glean object, since it sort of logically makes sense there. However, libraries need to register pings at any time during startup, including before `Glean::initialize` is called. Since we've tied `new` and `initialize` together, we couldn't add pings to the ping registry before the Glean singleton is initialized, since before that there is no Rust-side Glean object. An alternative to make that work would be to split `new` and `initialize` apart again, which isn't great. So I came up with this solution which uses an actual global object and state on the Rust side. It's not bad, but it does mean for testing that there is state carried over between tests. Tl;dr: I thought this could use more feedback / brainstorming before filling out the rest of the pieces. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly   160544457 pull {"url": "https://api.github.com/repos/mozilla/glean/issues/85/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 0   {"login": "mdboom", "id": 38294, "node_id": "MDQ6VXNlcjM4Mjk0", "avatar_url": "https://avatars.githubusercontent.com/u/38294?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mdboom", "html_url": "https://github.com/mdboom", "followers_url": "https://api.github.com/users/mdboom/followers", "following_url": "https://api.github.com/users/mdboom/following{/other_user}", "gists_url": "https://api.github.com/users/mdboom/gists{/gist_id}", "starred_url": "https://api.github.com/users/mdboom/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mdboom/subscriptions", "organizations_url": "https://api.github.com/users/mdboom/orgs", "repos_url": "https://api.github.com/users/mdboom/repos", "events_url": "https://api.github.com/users/mdboom/events{/privacy}", "received_events_url": "https://api.github.com/users/mdboom/received_events", "type": "User", "user_view_type": "public", "site_admin": false}       []

Links from other tables