issues: 447718011

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason pull_request body performed_via_github_app repo type reactions draft state_reason closed_by sub_issues_summary issue_dependencies_summary pinned_comment issue_field_values
447718011 MDExOlB1bGxSZXF1ZXN0MjgxNjU3NzE2 90 Bug 1553424 - Fix C example (was: log on invalid handles, but don't crash) 2129 closed 0     5 2019-05-23T15:05:58Z 2019-05-24T13:27:22Z 2019-05-24T13:27:19Z MEMBER   mozilla/glean/pulls/90 We never return an error and we certainly don't expect too many. Yet we should log them _when we_ encounter them. In debug mode we crash, in release we don't (that's what `debug_assert` is). Now for the handle thing, do we want to avoid crashing even in debug mode when we get an invalid one? It certainly points to an error which we might want to see in debug (and the thing that made us aware, calling `set_upload_enabled` before init will get fixed in another way anyway). Plus, so far we initialize logging during init, saving us a check at other points, but this means our `invalid handle used` log might actually get lost when it happens before the init. wdyt? ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly   160544457 pull {"url": "https://api.github.com/repos/mozilla/glean/issues/90/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 0   {"login": "badboy", "id": 2129, "node_id": "MDQ6VXNlcjIxMjk=", "avatar_url": "https://avatars.githubusercontent.com/u/2129?v=4", "gravatar_id": "", "url": "https://api.github.com/users/badboy", "html_url": "https://github.com/badboy", "followers_url": "https://api.github.com/users/badboy/followers", "following_url": "https://api.github.com/users/badboy/following{/other_user}", "gists_url": "https://api.github.com/users/badboy/gists{/gist_id}", "starred_url": "https://api.github.com/users/badboy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/badboy/subscriptions", "organizations_url": "https://api.github.com/users/badboy/orgs", "repos_url": "https://api.github.com/users/badboy/repos", "events_url": "https://api.github.com/users/badboy/events{/privacy}", "received_events_url": "https://api.github.com/users/badboy/received_events", "type": "User", "user_view_type": "public", "site_admin": false}       []

Links from other tables