home / github

Menu
  • ripgrep search
  • Dashboards

pull_requests

3,617 rows

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: state, locked, assignee, milestone, draft, created_at (date), updated_at (date), closed_at (date), merged_at (date)

id ▼ node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by stack
263236200 MDExOlB1bGxSZXF1ZXN0MjYzMjM2MjAw 1 closed 0 Add CircleCI configuration with doc generation & deployment badboy 2129   2019-03-21T13:32:03Z 2019-03-21T13:39:45Z 2019-03-21T13:39:43Z 2019-03-21T13:39:43Z 736f20a187c127ed24008a4d2fc00213864d2e56     0 0bcde3668e059a20cb8db8e3cdd8dcf68aacde5a e9fa3c355f8840d5310c9f409ab082bb7a37ba04 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/1    
263239226 MDExOlB1bGxSZXF1ZXN0MjYzMjM5MjI2 2 closed 0 Setup iOS project badboy 2129   2019-03-21T13:40:24Z 2019-03-27T19:04:21Z 2019-03-27T19:04:04Z 2019-03-27T19:04:04Z a6923c6a0f48f4d26f763db53da71639df5aa7f6     0 93c0885342c3e981aac846f2026ba74e5d83fdaf 59a6b1b06b761b677a8ecea1946653c4a1f06f8f MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/2    
263632932 MDExOlB1bGxSZXF1ZXN0MjYzNjMyOTMy 3 closed 0 Setup Android project badboy 2129   2019-03-22T14:25:50Z 2019-03-27T17:49:02Z 2019-03-27T17:47:21Z 2019-03-27T17:47:21Z 59a6b1b06b761b677a8ecea1946653c4a1f06f8f     0 4b85c019a545d015e5dd6947b3c748c589cbf0d3 736f20a187c127ed24008a4d2fc00213864d2e56 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/3    
266742116 MDExOlB1bGxSZXF1ZXN0MjY2NzQyMTE2 4 closed 0 Branding is important mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-04-02T17:34:25Z 2020-04-14T19:09:02Z 2019-04-30T12:30:48Z 2019-04-30T12:30:48Z cd31d715ac0107b23142f8282aee61fceb6d6da9     0 bca2b27a563cda6d8ac8b8cdb44bb29782275ae1 b5a24bca9001274e67f037c6e7980a4251f68660 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/4    
274711390 MDExOlB1bGxSZXF1ZXN0Mjc0NzExMzkw 5 closed 0 With rkv badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-04-30T12:31:26Z 2025-07-30T10:03:57Z 2019-04-30T12:56:19Z 2019-04-30T12:56:19Z 0e87a6376a937d54aa88c50d8b190f6a8e6a027e     0 7efed3ebacbae56e039a0eebb41cec1f1abb8b95 e2a7a0553f321bcd0ce4e48b029fc8bed4795080 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/5    
276922192 MDExOlB1bGxSZXF1ZXN0Mjc2OTIyMTky 6 closed 0 Move the storage details to a separate module Dexterp37 883721 This PR moves the rkv implementation details, including Lifetime.Application handling, to the newly introduced Database module. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T09:30:43Z 2019-05-08T10:06:02Z 2019-05-08T10:06:02Z 2019-05-08T10:06:01Z 388a44c0940e7ec49f11ed7b02ec69d6f49e7605     0 b4dec7130462fbe3e81cdd667e0ff01aab44e9d9 45fa2efebb69c8680437fd74bdb6e542a8f15705 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/6    
276925944 MDExOlB1bGxSZXF1ZXN0Mjc2OTI1OTQ0 7 closed 0 Store pings to disk mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T09:42:17Z 2020-04-02T16:48:54Z 2019-05-08T11:48:22Z 2019-05-08T11:48:22Z 523f76fa69a962b74ec4aae8cd998eef6d6877d6     0 9742038465390b27c409292773dc2825b1ec1c7a 388a44c0940e7ec49f11ed7b02ec69d6f49e7605 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/7    
276972068 MDExOlB1bGxSZXF1ZXN0Mjc2OTcyMDY4 8 closed 0 No more singleton badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T12:09:42Z 2019-05-09T09:20:31Z 2019-05-08T12:51:37Z 2019-05-08T12:51:37Z ec6c604a58b078664cbd6179e9f0d06664cc3a9e     0 5bbb46d2286ffb585c78a5e41cf105cf0ef0e217 523f76fa69a962b74ec4aae8cd998eef6d6877d6 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/8    
276978409 MDExOlB1bGxSZXF1ZXN0Mjc2OTc4NDA5 9 closed 0 WIP: Validate jsonschema in integration tests mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T12:30:13Z 2020-04-14T18:48:39Z 2019-06-07T12:38:25Z   cde1533425d6b0429730aa88108959d596b43f63     0 d848e4f14ba5bff3e4a378543fba73fb1dfdba89 523f76fa69a962b74ec4aae8cd998eef6d6877d6 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/9    
276985470 MDExOlB1bGxSZXF1ZXN0Mjc2OTg1NDcw 12 closed 0 Api playground badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T12:52:21Z 2025-07-30T10:04:51Z 2019-05-08T13:01:35Z 2019-05-08T13:01:35Z fb44796fe856fee7fdf96b0a0f774be51685f411     0 ec6c604a58b078664cbd6179e9f0d06664cc3a9e 565cc7b773e6a363c65cff66e298e4d2c4d37488 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/12    
276993821 MDExOlB1bGxSZXF1ZXN0Mjc2OTkzODIx 13 closed 0 Pass around the object to access its state badboy 2129 Fixes #11 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T13:16:45Z 2019-05-08T15:22:47Z 2019-05-08T14:01:36Z 2019-05-08T14:01:36Z 48e06ed73c84a2a07c6e3696e8d01342ac22d850     0 094390e7030f402be0f8b60caca3b6d98f3a1b2c fb44796fe856fee7fdf96b0a0f774be51685f411 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/13    
277053758 MDExOlB1bGxSZXF1ZXN0Mjc3MDUzNzU4 15 closed 0 Implement API to get the value back from a metric badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T15:50:37Z 2019-05-09T09:56:35Z 2019-05-09T09:56:31Z 2019-05-09T09:56:31Z d2fe269045a1a5657db6379043f784edc04c0763     0 4cce42c48fb2e47f1c15dcb8fa3db4ee1078e099 48e06ed73c84a2a07c6e3696e8d01342ac22d850 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/15    
277053886 MDExOlB1bGxSZXF1ZXN0Mjc3MDUzODg2 16 closed 0 Add test coverage for Database record Dexterp37 883721 This additionally moves some Database specific detail (i.e. storage names formatted as "{}#") back to the Database. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-08T15:51:00Z 2019-05-09T10:10:03Z 2019-05-09T10:10:02Z 2019-05-09T10:10:02Z 3a21db06bffad72bba2048039f4ecdec7bb59120     0 0158649be04c434ad830ade8e43e7da9884e3945 d2fe269045a1a5657db6379043f784edc04c0763 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/16    
277297615 MDExOlB1bGxSZXF1ZXN0Mjc3Mjk3NjE1 17 closed 0 Add simple Kotlin test mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T08:34:49Z 2020-04-14T19:09:02Z 2019-05-09T11:15:17Z 2019-05-09T11:15:17Z 66e39a524a20688c6016743c420ad2743cc15c6c     0 6672f1ee1baf3e43d150ee8d5164ad43c51d4762 3a21db06bffad72bba2048039f4ecdec7bb59120 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/17    
277374672 MDExOlB1bGxSZXF1ZXN0Mjc3Mzc0Njcy 18 closed 0 Pass meta data badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T12:37:33Z 2019-05-09T13:13:21Z 2019-05-09T13:03:53Z 2019-05-09T13:03:53Z c99ce4ba0a9ef8b6cffefb7538b495d7c8a053a7     0 1117181c7d17f316a6ebb68d7542c76c6f73facd 66e39a524a20688c6016743c420ad2743cc15c6c MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/18    
277382560 MDExOlB1bGxSZXF1ZXN0Mjc3MzgyNTYw 20 closed 0 Introduce automatic metrics generation Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T13:01:20Z 2019-05-09T13:40:27Z 2019-05-09T13:40:27Z 2019-05-09T13:40:27Z bf0a58ddce0dc629ce1e5b7af2dc46244b28190a     0 2ef559b53df9a5acadc3f67bd5fe4e4c0b2943a7 c99ce4ba0a9ef8b6cffefb7538b495d7c8a053a7 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/20    
277387929 MDExOlB1bGxSZXF1ZXN0Mjc3Mzg3OTI5 21 closed 0 Don't handle the array when getting a null pointer badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T13:16:20Z 2019-05-09T13:52:50Z 2019-05-09T13:49:36Z 2019-05-09T13:49:36Z 474848394cd2ad3e5dc1192f797ef589ea713779     0 a95af6bb2ab694e980af16547cf9d9ba7ee1244f bf0a58ddce0dc629ce1e5b7af2dc46244b28190a MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/21    
277402597 MDExOlB1bGxSZXF1ZXN0Mjc3NDAyNTk3 22 closed 0 Add handleBackgroundEvent mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T13:54:29Z 2020-04-14T19:09:22Z 2019-05-09T14:24:46Z 2019-05-09T14:24:46Z 701549c96baedc1300585207f5b9e8261620353e     0 061a4e8a47ef3e6244bcfcd228c63510725748f0 474848394cd2ad3e5dc1192f797ef589ea713779 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/22    
277414180 MDExOlB1bGxSZXF1ZXN0Mjc3NDE0MTgw 23 closed 0 Add a few core metrics Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T14:23:47Z 2019-05-09T14:42:08Z 2019-05-09T14:42:08Z 2019-05-09T14:42:08Z 6553128441748dcbe5788f2cee913aa78417e9de     0 291030c44bdf2be4d059b53e79cf96375d60eba2 474848394cd2ad3e5dc1192f797ef589ea713779 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/23    
277415312 MDExOlB1bGxSZXF1ZXN0Mjc3NDE1MzEy 24 closed 0 Sample generate badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T14:26:30Z 2019-05-09T14:59:22Z 2019-05-09T14:56:04Z 2019-05-09T14:56:04Z 128224e554d512c159ccef7c155062f8a1c6977d     0 047ba7a4c480819eb98a9b9e8362ed248f5c38c0 701549c96baedc1300585207f5b9e8261620353e MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/24    
277415382 MDExOlB1bGxSZXF1ZXN0Mjc3NDE1Mzgy 25 closed 0 Make use of test API badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T14:26:42Z 2019-05-09T14:59:37Z 2019-05-09T14:58:48Z 2019-05-09T14:58:48Z 5e48c9e1f9500f55d4ba804ecbb6a394ab9fe20f     0 d074af41f3dfe2dff36bc456a3bafcee8d15add4 701549c96baedc1300585207f5b9e8261620353e MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/25    
277427651 MDExOlB1bGxSZXF1ZXN0Mjc3NDI3NjUx 27 closed 0 Expose test api badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T14:56:19Z 2019-05-09T15:00:17Z 2019-05-09T15:00:10Z 2019-05-09T15:00:10Z b22ab8be19164fcfe3fc446a098de14767bd26bf     0 4c14c3c45973e25ddcd9f27f92692c3397cbf971 128224e554d512c159ccef7c155062f8a1c6977d MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/27    
277439946 MDExOlB1bGxSZXF1ZXN0Mjc3NDM5OTQ2 37 closed 0 Send a ping from the button mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T15:27:39Z 2020-04-14T19:09:23Z 2019-05-09T15:32:00Z 2019-05-09T15:32:00Z e63c63e8bed640a312ec9fea13087d910c1ea512     0 a3fc0fb56fa5308eb30c16598839b94c2a3aefdd b22ab8be19164fcfe3fc446a098de14767bd26bf CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/37    
277447006 MDExOlB1bGxSZXF1ZXN0Mjc3NDQ3MDA2 38 closed 0 Add smoke values for common fields to make valid pings Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T15:45:32Z 2019-05-09T15:53:02Z 2019-05-09T15:53:02Z 2019-05-09T15:53:02Z b9e7a144e011087bf9a35edaf4b1a136b34d429b     0 db693d720226952f3881672e95519667e15c7de8 e63c63e8bed640a312ec9fea13087d910c1ea512 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/38    
277460673 MDExOlB1bGxSZXF1ZXN0Mjc3NDYwNjcz 40 closed 0 Include android resources when running tests badboy 2129 This ... seems to fix the build issues. Fixes #39 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-09T16:23:28Z 2019-05-09T16:25:29Z 2019-05-09T16:25:24Z 2019-05-09T16:25:24Z ca6ffdcde5b09f13ce9363ecdfb51772c7a9298a     0 2bd57b6c6031208f98aab1bbe48bbbf9d1310299 b9e7a144e011087bf9a35edaf4b1a136b34d429b MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/40    
277681286 MDExOlB1bGxSZXF1ZXN0Mjc3NjgxMjg2 41 closed 0 Import test coverage from Glean-legacy for Counters and Strings Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-10T08:41:08Z 2019-05-10T11:56:41Z 2019-05-10T11:56:41Z 2019-05-10T11:56:40Z 46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b     0 202ee528a27d9d3a831ba88f5a87310d2a27e9fe 139fdd72efbeecd9c22ec1e0749e2ee4eaa920bf MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/41    
277682137 MDExOlB1bGxSZXF1ZXN0Mjc3NjgyMTM3 42 closed 0 Enable gradle tests on CI badboy 2129 Fixes #34 2019-05-10T08:43:54Z 2019-05-10T08:51:39Z 2019-05-10T08:50:17Z 2019-05-10T08:50:17Z 1394f43e8bcc5b1c54df24a8a69cfff01da15378     0 a4087602a331f878640ae03d5e4fd077e3533a51 ca6ffdcde5b09f13ce9363ecdfb51772c7a9298a MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/42    
277692131 MDExOlB1bGxSZXF1ZXN0Mjc3NjkyMTMx 44 closed 0 Install mdbook from released binary badboy 2129 This should speed up documentation generation by a bit. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-10T09:14:54Z 2019-05-10T15:07:30Z 2019-05-10T09:46:53Z 2019-05-10T09:46:53Z b9c234e02a1b00ac195d96776212a97b16e6d0f4     0 106dd6a73b1d576203a3e86557290985302a73be 1394f43e8bcc5b1c54df24a8a69cfff01da15378 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/44    
277697390 MDExOlB1bGxSZXF1ZXN0Mjc3Njk3Mzkw 45 closed 0 Be more dynamic in use of glean_parser mdboom 38294 This moves the `sdk_generator.gradle` file back to something that could be more easily shared between legacy glean and glean.rs by adding config variables for the things that need to be different. Also, this will no longer download glean_parser on every build. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-10T09:30:11Z 2020-04-14T19:09:21Z 2019-05-10T10:09:37Z 2019-05-10T10:09:37Z 139fdd72efbeecd9c22ec1e0749e2ee4eaa920bf     0 d2a3e5ce3ee452ecbbf284fbb639825624c350da 1394f43e8bcc5b1c54df24a8a69cfff01da15378 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/45    
277810056 MDExOlB1bGxSZXF1ZXN0Mjc3ODEwMDU2 47 closed 0 WIP: Use a counter for the sequence number per ping badboy 2129 This mis-uses our test-only API right now to get back the value and encodes the ping name into the key. NOT READY TO BE MERGED! 2019-05-10T15:16:02Z 2019-07-10T16:33:16Z 2019-06-05T09:05:09Z   f2dbae03e6e045743c493024f91a8b90aa68204e     0 d1d9a077d1581ef062650bfe935e8dc7e9ffd039 46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/47    
278184142 MDExOlB1bGxSZXF1ZXN0Mjc4MTg0MTQy 48 closed 0 Update the developer setup notes Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-13T09:07:07Z 2019-05-13T09:38:24Z 2019-05-13T09:38:24Z 2019-05-13T09:38:24Z 4f6159c10b91bd2ee17f4c521b15311f58ee9014     0 08224a823f149229a20eb8671c6f20072e1c3b23 46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/48    
278187324 MDExOlB1bGxSZXF1ZXN0Mjc4MTg3MzI0 49 closed 0 Add the MPL 2.0 license header to all the source code files Dexterp37 883721 This closes #28 . ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-13T09:16:00Z 2019-05-13T09:22:27Z 2019-05-13T09:22:27Z 2019-05-13T09:22:27Z d2fe97cdf6ca2896dfd4f3d50b48ab5199db6c90     0 d1e9a454661e1d1e3b49e7689a4083245176d1cf 46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/49    
278235759 MDExOlB1bGxSZXF1ZXN0Mjc4MjM1NzU5 50 closed 0 Disclaimer badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-13T11:38:47Z 2019-05-13T14:46:34Z 2019-05-13T13:28:16Z 2019-05-13T13:28:16Z e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb     0 32ff39b644134baf16f362913f8452649c2c2c90 4f6159c10b91bd2ee17f4c521b15311f58ee9014 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/50    
278238857 MDExOlB1bGxSZXF1ZXN0Mjc4MjM4ODU3 51 closed 0 Initialize objects on creation badboy 2129 Fixes #29 This is in preparation of the [error handling](https://bugzilla.mozilla.org/show_bug.cgi?id=1551141) so that I don't have to touch these parts again. 2019-05-13T11:48:46Z 2019-05-13T15:02:35Z 2019-05-13T13:28:03Z 2019-05-13T13:28:03Z fae652593c1d3a74df76898fc6407635cfe5fd8d     0 df83047d0fa0696a534536a9ba7d7421d543c192 4f6159c10b91bd2ee17f4c521b15311f58ee9014 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/51    
278256082 MDExOlB1bGxSZXF1ZXN0Mjc4MjU2MDgy 52 closed 0 Generically handle error badboy 2129 (Based on #51, that needs to be merged first) This is a first try at removing most `.unwrap`s in the code. There are some left, mostly in database operations, which should be done in a followup. The way it works is it's always passing errors up until the FFI layer, where errors are logged and a potential default value for the FFI type is returned (e.g. a null pointer for pointers or 0 for the handle). The Kotlin side needs to check these values (only relevant for glean object creation and metric constructor) (This also includes a couple of semi-related commits to update the generated C header and adding the license header where it was missing, hope that's not too distracting) 2019-05-13T12:40:45Z 2019-05-15T07:54:53Z 2019-05-15T07:54:48Z 2019-05-15T07:54:48Z 490bb816666d7b2703d83c3461028b75d05792e7     0 ac30a91afe04bc3d0f29c7a005a0dfe461ba6864 d0c657239111995bc4fc804d617bfec5686b477f MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/52    
278301369 MDExOlB1bGxSZXF1ZXN0Mjc4MzAxMzY5 53 closed 0 Backport updates from application-services gradle files Dexterp37 883721 This applies the changes from [c40e2cc in mozilla/application-services](https://github.com/mozilla/application-services/tree/c40e2ccb422cf4af9ffdf095149cec34de1d4bef) to our repo, with minimal tweaks due to the different directory layout and the glean parsers integration. **Note** - klint and detekt are currently not invoked on CI, even though they can run manually, because we have dozens of errors :) ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-13T14:31:59Z 2019-05-14T08:01:20Z 2019-05-14T08:01:20Z 2019-05-14T08:01:20Z 19c1cf3dfe6ee4983b94e0ffca129e524144b229     0 c2308caf3c9162d6db3954251759b9a1d2db75d4 e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/53    
278302807 MDExOlB1bGxSZXF1ZXN0Mjc4MzAyODA3 54 closed 0 Enable parallel testing on CI badboy 2129 Now that we've removed the singletons, this works Fixes #33 2019-05-13T14:35:18Z 2019-05-13T14:46:20Z 2019-05-13T14:46:05Z 2019-05-13T14:46:05Z 2155cd1802673ec5368ba7c1f0af790176dd48bb     0 2b8d38dd42c3586a1012c7c65e46b61dec6f645b e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/54    
278410267 MDExOlB1bGxSZXF1ZXN0Mjc4NDEwMjY3 55 closed 0 1551145: Copy over Kotlin simple public API tests mdboom 38294 This is a first pass at moving over the Kotlin public API tests from glean-ac, and mocking out what needs to be in order to make them compile. The things that aren't brought over (because they would require excessive mocking) are: - `TimingDistribution` - Labeled metrics - Error metrics Personally, I'm most concerned about making sure our test coverage is easy to cross-reference against glean-ac, so I don't have a problem deferring those files for now, since it's clear by comparing against glean-ac that they are missing, and bringing them over once those features get fleshed out. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-13T19:49:02Z 2020-04-14T19:09:32Z 2019-05-14T13:18:53Z 2019-05-14T13:18:53Z 821cc6579854d81cfd44d4b23f455921f3f33d38     0 8c560bb78121e7eed229c661fcf256b34cef7704 2155cd1802673ec5368ba7c1f0af790176dd48bb CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/55    
278572579 MDExOlB1bGxSZXF1ZXN0Mjc4NTcyNTc5 56 closed 0 Add (empty) detekt config to make detekt happy badboy 2129 `./gradlew detekt` didn't run for me without that file locally. Here's application-services file: https://github.com/mozilla/application-services/blob/377c1580deb21b9e17f8ba6d36e2565bab0891a5/.detekt.yml It's 500 lines long. I don't like that and I don't understand roughly 499 of those lines, so I opted for having the most minimal working config instead. Edit: after more testing and chatting I removed the config file from the build.gradle. We can add it back when we _do_ need to change the config. 2019-05-14T08:29:02Z 2019-07-10T16:33:47Z 2019-05-14T09:34:19Z 2019-05-14T09:34:19Z 212b24ecd83b3495b18fdebb65cc16fe12db0b34     0 684a990bfda16e36d6096c230d0227177d3b5ade 19c1cf3dfe6ee4983b94e0ffca129e524144b229 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/56    
278668523 MDExOlB1bGxSZXF1ZXN0Mjc4NjY4NTIz 57 closed 0 Turn stateless PingMaker into free functions badboy 2129 Fixes #31 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-14T12:52:38Z 2019-08-16T09:22:56Z 2019-05-14T14:49:58Z   7dc9d6961b8ba85d1cfb094edb46a76840c63043     0 ec71921240f9731d7f2a493fd5f7718ac9204e94 212b24ecd83b3495b18fdebb65cc16fe12db0b34 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/57    
278668733 MDExOlB1bGxSZXF1ZXN0Mjc4NjY4NzMz 58 closed 0 Dont send pings if empty badboy 2129 Based on #57 2019-05-14T12:53:11Z 2019-05-15T13:19:55Z 2019-05-15T13:19:52Z 2019-05-15T13:19:52Z cc60dc80de4959533a1e670096db6de45f540e28     0 c7983d46df5e4c5597f24eb0778c113e3916a074 955efe905d9034b3284388c541f1d600a84f0e46 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/58    
278684649 MDExOlB1bGxSZXF1ZXN0Mjc4Njg0NjQ5 59 closed 0 1551258: Fix Kotlin linting and enable on CI mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-14T13:31:40Z 2020-04-14T19:09:26Z 2019-05-14T14:54:34Z 2019-05-14T14:54:34Z d0c657239111995bc4fc804d617bfec5686b477f     0 525f2be26c0a24b28a8410b1ec2cc27005e4b988 821cc6579854d81cfd44d4b23f455921f3f33d38 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/59    
278837484 MDExOlB1bGxSZXF1ZXN0Mjc4ODM3NDg0 60 closed 0 1551153: Enable the ping uploader in glean-core mdboom 38294 We have upload \o/ (Well, mostly thanks to copying a bunch of already working code over from glean-ac -- thanks to @travis79 and @Dexterp37). The first commit just copies the files from glean-ac over. The second commit includes the changes to make them work in the new context. So it might be easier to review by only looking at the second commit in order to ignore things that were already reviewed on the glean-ac side. There are a few TODOs here, with bugs already created and noted. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-14T20:23:04Z 2020-04-14T19:09:03Z 2019-05-15T14:39:42Z 2019-05-15T14:39:42Z 2d6995a03d9c682e8c6ab1c45b58506cd150c4dc     0 af4c3741cae19c8e493df20ad12dabe15cc31ca3 cc60dc80de4959533a1e670096db6de45f540e28 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/60    
278861118 MDExOlB1bGxSZXF1ZXN0Mjc4ODYxMTE4 61 closed 0 Use Android 27 docker image mdboom 38294 The Android 27 SDK ends up getting downloaded by the build script. Using the Docker image with that version already baked should save on CI runtime, theoretically, though we should confirm that before merging. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-14T21:36:45Z 2020-04-02T16:47:23Z 2019-05-15T08:04:05Z 2019-05-15T08:04:05Z 955efe905d9034b3284388c541f1d600a84f0e46     0 06a03577884cf95952a804d242b0a1b185db6ba7 d0c657239111995bc4fc804d617bfec5686b477f CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/61    
279000663 MDExOlB1bGxSZXF1ZXN0Mjc5MDAwNjYz 62 closed 0 Update links and naming across the repository badboy 2129   2019-05-15T09:00:18Z 2019-07-10T16:33:11Z 2019-05-15T12:12:29Z 2019-05-15T12:12:29Z bd2abd819f76ff70ff2fe8754dc21c3cbe53cea0     0 ce797e9191a038a1b7bbe494e528c83ff2dd6779 955efe905d9034b3284388c541f1d600a84f0e46 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/62    
279043422 MDExOlB1bGxSZXF1ZXN0Mjc5MDQzNDIy 63 closed 0 Expose an internal sync API and make the public API async Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-15T10:54:59Z 2019-05-15T12:48:17Z 2019-05-15T12:48:17Z 2019-05-15T12:48:17Z 24760b4bbb7b937f7ec11553e53ba077d01e30e9     0 9c806ee1755077b1c6d71cefaa87c74f6b27d25a 955efe905d9034b3284388c541f1d600a84f0e46 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/63    
279104894 MDExOlB1bGxSZXF1ZXN0Mjc5MTA0ODk0 64 closed 0 Bug 1551863 - Pass missing disabled flag to Rust side badboy 2129   2019-05-15T13:44:15Z 2019-05-15T14:35:37Z 2019-05-15T14:35:06Z 2019-05-15T14:35:06Z 3c663feb4620b67d127e71215aea7c0e365e9eb8     0 fe47fdaabf65b7be69bf46655e1ef88164ac3dba cc60dc80de4959533a1e670096db6de45f540e28 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/64    
279147951 MDExOlB1bGxSZXF1ZXN0Mjc5MTQ3OTUx 65 closed 0 Bug 1551892: Implement the testing API for the StringMetricType and enable the related tests badboy 2129   2019-05-15T15:21:46Z 2019-05-16T07:25:39Z 2019-05-16T07:25:35Z 2019-05-16T07:25:35Z dbdeff47fd727688d3fda35ba1996335ac6c33c1     0 a7a2a9c50ad2e6ea351c9c07f22fbaf52e4933f4 2d6995a03d9c682e8c6ab1c45b58506cd150c4dc MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/65    
279201921 MDExOlB1bGxSZXF1ZXN0Mjc5MjAxOTIx 66 closed 0 Update pull_request_template.md mdboom 38294 This makes it more language-agnostic. I like using the `Makefile` for these conveniences, and I kind of like maintaining the Makefile indefinitely as a source of developer conveniences (as long is it doesn't become the "real" build tool). But I don't know how well it works on Windows. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-15T17:54:13Z 2020-04-02T16:49:55Z 2019-05-16T15:37:33Z 2019-05-16T15:37:33Z ccef0fd863560e4ca3555db7405ffd0528416d15     0 d897aa400a71c50a42e7df4d1837aa4567d4c95f 2d6995a03d9c682e8c6ab1c45b58506cd150c4dc CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/66    
279212992 MDExOlB1bGxSZXF1ZXN0Mjc5MjEyOTky 67 closed 0 1551692: Don't schedule the uploading worker if no ping queued mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-15T18:28:22Z 2020-04-14T19:09:10Z 2019-05-16T22:07:22Z 2019-05-16T22:07:22Z 110e44584de68a960e92542903b0c3e093f3eaa4     0 420f025ecd084fa59859b570dd7e1d700853b62e ccef0fd863560e4ca3555db7405ffd0528416d15 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/67    
279443377 MDExOlB1bGxSZXF1ZXN0Mjc5NDQzMzc3 68 closed 0 Add a Contact section to the readme file Dexterp37 883721 This also updates the bugzilla new bug template to add the expected priority and whiteboard tag so that bugs show up on bugzhub. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-16T10:29:07Z 2020-06-05T09:06:00Z 2019-05-16T10:38:52Z 2019-05-16T10:38:52Z 033f0550ead2fab04b3cb1a3853376e8e74dd2c9     0 3ea524658762a069ba030b7de2cd4fd8563d5f77 dbdeff47fd727688d3fda35ba1996335ac6c33c1 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/68    
279449077 MDExOlB1bGxSZXF1ZXN0Mjc5NDQ5MDc3 69 closed 0 Enable checking for Dispatcher's test mode in the test API Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-16T10:44:56Z 2019-05-16T15:04:46Z 2019-05-16T15:04:45Z 2019-05-16T15:04:45Z 1fbc891c55484fdac7e8f498a67af7f8ba42ee8c     0 96d5fea88d3bfc1dabf5cfe4e3070ec6721dca75 435dbde0244584aece48a72fcb00982caab6152b MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/69    
279475021 MDExOlB1bGxSZXF1ZXN0Mjc5NDc1MDIx 70 closed 0 Use i32 everywhere for counters badboy 2129 We actually should use u32 internally, but: because Kotlin doesn't (yet) have unsigned integers, it's always going to pass us signed values. We also do all the error checking on the Rust side, so we need to receive the signed value to check for negativity and bail out. We still don't do overflow checks though. [Bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1552131) ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-16T12:04:02Z 2019-05-16T12:49:24Z 2019-05-16T12:48:56Z 2019-05-16T12:48:56Z 7681ddd65a5137895ec8a9a3c85ff20c3e2eea4c     0 d3e4f01df7b807c4fc956e3ca396444b5816c4ac 033f0550ead2fab04b3cb1a3853376e8e74dd2c9 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/70    
279475704 MDExOlB1bGxSZXF1ZXN0Mjc5NDc1NzA0 71 closed 0 Small edits on makefile badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `cargo clean; cargo test --all` runs without emitting any warnings - `cargo fmt` does not produce any changes to the code - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly 2019-05-16T12:06:03Z 2019-05-16T15:11:55Z 2019-05-16T14:11:31Z 2019-05-16T14:11:31Z 435dbde0244584aece48a72fcb00982caab6152b     0 634f447dfb40be9ac78db6503bbfd8fbc537d9a3 033f0550ead2fab04b3cb1a3853376e8e74dd2c9 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/71    
279651607 MDExOlB1bGxSZXF1ZXN0Mjc5NjUxNjA3 72 closed 0 1552122: Initial port (with some stubbing) of Glean core API mdboom 38294 This moves over the public API on the Glean object. I have also reorganized the other of the methods in `Glean.kt` so it matches glean-ac (which should make it easier to do line-by-line comparisons). Again, the first commit is copying some files from glean-ac over verbatim. The second commit then modifies them for our context. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-16T20:08:10Z 2020-04-14T19:09:01Z 2019-05-20T13:12:16Z 2019-05-20T13:12:16Z dd5439695d70a1a4db57caff517763fa251fd533     0 a9b1d59c0f2ae09a326dfae367bcffc5a16d13e9 b8dc19d966445050cb977e2dcf6636142eae3097 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/72    
279864368 MDExOlB1bGxSZXF1ZXN0Mjc5ODY0MzY4 73 closed 0 1552474: Add a Byte.toBoolean convenience function mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-17T12:00:31Z 2020-04-14T19:09:03Z 2019-05-17T12:47:37Z 2019-05-17T12:47:37Z b8dc19d966445050cb977e2dcf6636142eae3097     0 51b87bfe16f26ca715c71e33a336661757f1f27b 110e44584de68a960e92542903b0c3e093f3eaa4 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/73    
279887457 MDExOlB1bGxSZXF1ZXN0Mjc5ODg3NDU3 74 closed 0 Document how to add a new metric type in the code badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-17T13:13:52Z 2019-05-20T13:46:52Z 2019-05-20T13:28:57Z 2019-05-20T13:28:57Z 4403aa97f4c17fed1696373425478b67c69954e1     0 d2aef2950382d067891a50553fa56af4aae0f8f6 b8dc19d966445050cb977e2dcf6636142eae3097 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/74    
280006852 MDExOlB1bGxSZXF1ZXN0MjgwMDA2ODUy 75 closed 0 1552136: Convert CounterStorageEngineTests.kt to Rust mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-17T19:29:35Z 2020-04-02T16:47:29Z 2019-05-20T16:17:35Z 2019-05-20T16:17:35Z 91db2ca80c3ab223e059eef99aed82bc8b9f8ce5     0 bbc9036f2bb75e2fc7c204a7ab33754640111cbd 3b4ea95f6fde6823571e2c1572fabf8ef9a06c8a CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/75    
280305862 MDExOlB1bGxSZXF1ZXN0MjgwMzA1ODYy 76 closed 0 Default to a ping lifetime during conversion badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T09:19:44Z 2019-05-20T13:13:48Z 2019-05-20T13:13:17Z 2019-05-20T13:13:17Z 00033c3a957be5ed65eca611069586267698adf8     0 2d936138b0780c0ffb26eb229834a89667d630a0 b8dc19d966445050cb977e2dcf6636142eae3097 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/76    
280306728 MDExOlB1bGxSZXF1ZXN0MjgwMzA2NzI4 77 closed 0 Bug 1552511 - Use finalizers to destruct metrics badboy 2129 https://bugzilla.mozilla.org/show_bug.cgi?id=1552511 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T09:22:10Z 2019-05-20T13:47:25Z 2019-05-20T13:47:17Z 2019-05-20T13:47:17Z bb9ead2256c87922db8eae9452debe902bb22087     0 12ae60784c254944b22e6b28858f719e5db11c6f b8dc19d966445050cb977e2dcf6636142eae3097 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/77    
280383587 MDExOlB1bGxSZXF1ZXN0MjgwMzgzNTg3 78 closed 0 Bug 1552820 - Expose boolean test API and re-enable metric tests badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T13:07:02Z 2019-05-20T13:51:03Z 2019-05-20T13:48:25Z 2019-05-20T13:48:25Z a84711698cf744910f3c39107049cc8b191a56c7     0 00a9020f4ec1bb4445ba423ec08fab0e58c02dff b8dc19d966445050cb977e2dcf6636142eae3097 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/78    
280390678 MDExOlB1bGxSZXF1ZXN0MjgwMzkwNjc4 79 closed 0 Redirect logging to stdout in tests Dexterp37 883721 This enables a logger implementation on platforms that are not Android: we couldn't see any log beyond FFI for this reason, since tests are x86/x64. This additionally redirects Kotlin logcat to stdout in tests. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T13:24:56Z 2019-05-20T14:08:59Z 2019-05-20T14:08:59Z 2019-05-20T14:08:58Z 3b4ea95f6fde6823571e2c1572fabf8ef9a06c8a     0 666bfb01dded04c94d0793a3fcd861d0639a5ec4 00033c3a957be5ed65eca611069586267698adf8 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/79    
280459239 MDExOlB1bGxSZXF1ZXN0MjgwNDU5MjM5 80 closed 0 Bug 1552857 - Convert StringsStorageEngineTests.kt to Rust badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T16:19:55Z 2019-05-21T07:21:54Z 2019-05-21T07:20:43Z 2019-05-21T07:20:43Z 43d439c9a017b210d6fca9c45beb160a5fc2ccbe     0 d0551bf8a95b194f186031ffc307726c2c6ac042 91db2ca80c3ab223e059eef99aed82bc8b9f8ce5 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/80    
280537116 MDExOlB1bGxSZXF1ZXN0MjgwNTM3MTE2 81 closed 0 1547967: Include pings metadata mdboom 38294 This just copies over the updated `pings.yaml` from glean-ac and updates the glean_parser to a version that supports the new metadata. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-20T20:49:46Z 2020-04-02T16:49:49Z 2019-05-21T07:21:37Z 2019-05-21T07:21:37Z 3f04eb3242272207a3ca5557f65063a2f2e900ce     0 cfcffdb4233d196775d1a9ecf030dbbbd7f2d5b4 91db2ca80c3ab223e059eef99aed82bc8b9f8ce5 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/81    
280654393 MDExOlB1bGxSZXF1ZXN0MjgwNjU0Mzkz 82 closed 0 Bug 1552860 - Convert BooleansStorageEngineTests.kt to Rust badboy 2129 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-21T07:25:31Z 2019-05-21T08:13:08Z 2019-05-21T08:13:03Z 2019-05-21T08:13:03Z 5579f6ac78b071a31e66bb2a5bd9d86eabe255b7     0 bd69a2a74a55dca1e51604957e4f364ec3164534 3f04eb3242272207a3ca5557f65063a2f2e900ce MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/82    
280685529 MDExOlB1bGxSZXF1ZXN0MjgwNjg1NTI5 83 closed 0 Merge the latest changes from a-s gradle scripts Dexterp37 883721 This enables back artifact publishing by integrating back the changes to the gradle scripts up until changeset mozilla/application-services@5d8dd7b . This allows to publish glean-core to a local Maven repo with the following command: `./gradlew publishToMavenLocal` Once published, the package can be consumed by other applications built locally. Instructions on how to do that will come as part of [bug 1551156](https://bugzilla.mozilla.org/show_bug.cgi?id=1551156). ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-21T08:58:13Z 2019-05-21T12:30:17Z 2019-05-21T12:30:17Z 2019-05-21T12:30:17Z 4898bd0492278f3911afde21216c8b84ce1dd5f2     0 ebea36d08c6d5f8fa105e84b0b7a99cfcc86ece3 5579f6ac78b071a31e66bb2a5bd9d86eabe255b7 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/83    
280696831 MDExOlB1bGxSZXF1ZXN0MjgwNjk2ODMx 84 closed 0 Bug 1552850 - Implement shouldRecord on the Kotlin side badboy 2129 Posting this because the code part was easy, but I have some hesitations: * The `should_record` check _also_ happens on the Rust side * We do avoid putting any work in the Dispatcher queue with this. * The (Rust-side) check is on the metric and requires access to the glean object, therefore we need to re-implement it for every type * There might be a way of using traits here to implement it just once (we will need to "re-implement" exposing the common metric data though) * I opted for not doing that now (it's a refactoring, not blocking anything and the code duplication so far is simple) * We also need to duplicate code on the Kotlin side, because we need a `*_should_record` function per type. Unfortunately I don't see a way to avoid this (again, duplication here contains no complex logic so for now I'm fine with it) The biggest thing remains the first statement: Do we _need_ the check on the Kotlin side or is Rust-side only actually enough? (Dispatch enqueue cost?) ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-21T09:27:58Z 2019-05-23T11:31:31Z 2019-05-22T08:29:36Z 2019-05-22T08:29:36Z 18c4664884421d2367c93606a795dcec25e5feed     0 f49b9a5c004b5982372d838800edd61f8c71a98d 4898bd0492278f3911afde21216c8b84ce1dd5f2 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/84    
280919725 MDExOlB1bGxSZXF1ZXN0MjgwOTE5NzI1 85 closed 0 Move PingType metadata to the Rust side mdboom 38294 I'm just posting this here for discussion -- either here or in our next meeting if that's more efficient. FFI and Kotlin side not implemented yet. I first considered putting the ping registry on the Glean object, since it sort of logically makes sense there. However, libraries need to register pings at any time during startup, including before `Glean::initialize` is called. Since we've tied `new` and `initialize` together, we couldn't add pings to the ping registry before the Glean singleton is initialized, since before that there is no Rust-side Glean object. An alternative to make that work would be to split `new` and `initialize` apart again, which isn't great. So I came up with this solution which uses an actual global object and state on the Rust side. It's not bad, but it does mean for testing that there is state carried over between tests. Tl;dr: I thought this could use more feedback / brainstorming before filling out the rest of the pieces. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-21T19:36:27Z 2020-04-14T19:09:34Z 2019-05-28T22:02:16Z 2019-05-28T22:02:16Z dbcd3110388e977c06768a880e6ac06e62e2fa9f     0 64a40f65c18f3eee5b2d1cdc51f35abc41d6cf2a 085207a02764f7a28a52652094ad38834803b6dc CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/85    
281103540 MDExOlB1bGxSZXF1ZXN0MjgxMTAzNTQw 86 closed 0 Refactored should record badboy 2129 Bikeshed: Should we call the trait `MetricType` or something else? right now it only exposes the `meta()` method and the `should_record` method, but maybe we have more in the future? 2019-05-22T09:18:19Z 2019-05-23T11:30:32Z 2019-05-23T11:30:27Z 2019-05-23T11:30:27Z eee01c97b4d69faffd553ededf9c718f99cc492d     0 bd7f5217b30a64485a700554a8a5b7b9f562f64a 18c4664884421d2367c93606a795dcec25e5feed MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/86    
281112206 MDExOlB1bGxSZXF1ZXN0MjgxMTEyMjA2 87 closed 0 Refactor tests badboy 2129 I tried to keep a better organization of our Rust tests. I also moved away from ugly `String.contains` tests towards our existing test API or checking the JSON directly. StringList and UUID are only half-implemented so I didn't touch the tests. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-22T09:40:44Z 2019-05-23T13:41:30Z 2019-05-23T13:41:28Z 2019-05-23T13:41:28Z bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971     0 ec438b0022423abd356ca374cc426c670de83ac7 18c4664884421d2367c93606a795dcec25e5feed MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/87    
281177672 MDExOlB1bGxSZXF1ZXN0MjgxMTc3Njcy 88 closed 0 1553195 labeled metrics stub badboy 2129 First try at the labeled metrics. Makes use of the trait implementation in #86 (needs rebase when that gets merged). Notably lacking: Any Kotlin-side handling. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-22T12:46:22Z 2019-05-23T16:00:14Z 2019-05-23T16:00:09Z 2019-05-23T16:00:09Z bc0ff75ab707637b437328216db03bc4f0774126     0 d51b69e438fbdf6e83e67e41aad069fb00da6d6a bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/88    
281637129 MDExOlB1bGxSZXF1ZXN0MjgxNjM3MTI5 89 closed 0 Import GleanTest.kt from glean-ac Dexterp37 883721 Import the tests over from [this version GleanTest.kt](https://raw.githubusercontent.com/mozilla-mobile/android-components/8ef0d4b3247255ca6c456e9b5ab61338bc109209/components/service/glean/src/test/java/mozilla/components/service/glean/GleanTest.kt) from glean-ac. **Note**: the first commit simply overwrites the current test file we own. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-23T14:22:33Z 2019-05-24T08:31:34Z 2019-05-24T08:31:34Z 2019-05-24T08:31:34Z 05a11cd78e49c909b916dd4ccbb787b63787ffa9     0 8efb4090d913572fbcf98273d7c983e9893ad5fa bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/89    
281657716 MDExOlB1bGxSZXF1ZXN0MjgxNjU3NzE2 90 closed 0 Bug 1553424 - Fix C example (was: log on invalid handles, but don't crash) badboy 2129 We never return an error and we certainly don't expect too many. Yet we should log them _when we_ encounter them. In debug mode we crash, in release we don't (that's what `debug_assert` is). Now for the handle thing, do we want to avoid crashing even in debug mode when we get an invalid one? It certainly points to an error which we might want to see in debug (and the thing that made us aware, calling `set_upload_enabled` before init will get fixed in another way anyway). Plus, so far we initialize logging during init, saving us a check at other points, but this means our `invalid handle used` log might actually get lost when it happens before the init. wdyt? ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-23T15:05:58Z 2019-05-24T13:27:22Z 2019-05-24T13:27:19Z 2019-05-24T13:27:18Z 9bec98a76de15152d27b6fa6b26a76ba369ff173     0 f83385646b913d5c1e65be3e483b5efe6a0f7078 05a11cd78e49c909b916dd4ccbb787b63787ffa9 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/90    
281660607 MDExOlB1bGxSZXF1ZXN0MjgxNjYwNjA3 91 closed 0 Split linting into multiple tasks badboy 2129 This allows to only run clippy, which is much faster than its Kotlin counterpart. 2019-05-23T15:12:15Z 2019-05-23T15:58:45Z 2019-05-23T15:58:41Z 2019-05-23T15:58:41Z 40c6a9d3c6a5072eb3440c26b72f501871d3365e     0 fae6d3b1f5bde8d349af36ec556fe10a1e7b4c8c bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/91    
281948442 MDExOlB1bGxSZXF1ZXN0MjgxOTQ4NDQy 92 closed 0 Enable logging at load time badboy 2129 Based on #90, will rebase when that is merged. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-24T09:57:56Z 2019-05-27T09:29:43Z 2019-05-27T09:29:39Z 2019-05-27T09:29:39Z aac86901a48dde3b183095aac60eb49901a161fb     0 52ded22ebaa896203d6ae4eb61edab0be763da92 9bec98a76de15152d27b6fa6b26a76ba369ff173 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/92    
281954392 MDExOlB1bGxSZXF1ZXN0MjgxOTU0Mzky 93 closed 0 Bug 1553424 - Setting uploadEnabled before initialization should not crash badboy 2129 Follow up to #90 in which we now keep track of the flag before we initialize. We can eventually deprecate the "call before init" way and move the flag into the initializer. For now this is the easy way out of crashing. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-24T10:14:54Z 2019-05-27T14:49:33Z 2019-05-27T14:49:29Z 2019-05-27T14:49:29Z 207ba03d1a6f053a9be9bbfe441a14c196685d58     0 e5efa7d96c6692860c6ed525c03db7f27ae66945 aac86901a48dde3b183095aac60eb49901a161fb MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/93    
282536620 MDExOlB1bGxSZXF1ZXN0MjgyNTM2NjIw 94 closed 0 Stub out the TimingDistributionMetricType Dexterp37 883721 Just copying over files and commenting out things. There's no change to the files other than comments and the package name. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-27T14:31:26Z 2019-05-27T14:58:13Z 2019-05-27T14:58:13Z 2019-05-27T14:58:13Z cc8ddcf9f24045461e0a175ef4c26feab116cac1     0 796a2b4083e693705655c912ce7769b1b2202411 aac86901a48dde3b183095aac60eb49901a161fb MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/94    
282735380 MDExOlB1bGxSZXF1ZXN0MjgyNzM1Mzgw 95 closed 0 Bug 1552873 - Implement labeled metrics badboy 2129 A first try of implementing a (good enough) solution for the labeled metrics. I want to write a few more comments before I make this a full PR. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T09:08:55Z 2019-05-30T13:51:01Z 2019-05-29T08:34:52Z 2019-05-29T08:34:52Z bb69612ff31eb00dbd92f66378ffa2f7e616066a     0 94f87592053b5a113bc005052d6420b98ba727d9 dbcd3110388e977c06768a880e6ac06e62e2fa9f MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/95    
282749734 MDExOlB1bGxSZXF1ZXN0MjgyNzQ5NzM0 96 closed 0 `should_record` fixup Dexterp37 883721 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T09:45:18Z 2019-05-28T09:52:17Z 2019-05-28T09:52:17Z 2019-05-28T09:52:17Z b4c0e8fafaec7a82c6cc45b6480a3650f3f994af     0 9806e8e7dbf32d13082f5846485973e1c1fb487e cc8ddcf9f24045461e0a175ef4c26feab116cac1 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/96    
282759477 MDExOlB1bGxSZXF1ZXN0MjgyNzU5NDc3 97 closed 0 Add how to publish new metric types in the module Dexterp37 883721 Add the missing steps for properly exposing a new metric type. Without these steps, build will fail. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T10:09:32Z 2019-07-10T16:33:24Z 2019-05-28T12:21:50Z 2019-05-28T12:21:50Z 085207a02764f7a28a52652094ad38834803b6dc     0 04bd2b0341975044cc440bf77aa49d10ee0c8da4 b4c0e8fafaec7a82c6cc45b6480a3650f3f994af MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/97    
282791058 MDExOlB1bGxSZXF1ZXN0MjgyNzkxMDU4 98 closed 0 Snapshot a single metric badboy 2129 This avoids going awkwardly through a JSON-serialized storage and trying to find the right place. Extracted from #95 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T11:39:58Z 2019-05-28T15:07:21Z 2019-05-28T15:07:18Z 2019-05-28T15:07:18Z a4dff9bfa190f24a4a01e62f0acbfc05207da0b5     0 e6dfdc225401f2eab09a56c52b166db645c362bc b4c0e8fafaec7a82c6cc45b6480a3650f3f994af MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/98    
282880421 MDExOlB1bGxSZXF1ZXN0MjgyODgwNDIx 99 closed 0 Add error reporting for labeled metrics (and counters) badboy 2129 Based on #95, needs a rebase when that lands. The last 3 commits are relevant. We now have all things in place for error reporting using labeled metrics. Even though the error reporting itself doesn't use the labeled metrics, we simply depend on the same "encoding" of labels into the key. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T15:19:42Z 2019-06-05T08:24:37Z 2019-06-05T08:10:12Z 2019-06-05T08:10:12Z efdcd37604b4a6244478f406f5d5d9ad80604eff     0 55274abdeb48d0b7390b58efda5ceef7e53db30d b9379f2d8036fd22021b1df1666087918898e84f MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/99    
282903782 MDExOlB1bGxSZXF1ZXN0MjgyOTAzNzgy 100 closed 0 Bug 1555031 - Generate kotlin docs badboy 2129 With this `./gradlew docs` will generate HTML documentation in build/javadoc/glean.rs/ ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T16:17:28Z 2019-05-29T13:35:27Z 2019-05-29T13:35:13Z 2019-05-29T13:35:13Z f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132     0 dc88c0d3ded1d7274ec33cf622f8723ca305294d bb69612ff31eb00dbd92f66378ffa2f7e616066a MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/100    
282981219 MDExOlB1bGxSZXF1ZXN0MjgyOTgxMjE5 101 closed 0 Add Kotlin docs to CI mdboom 38294 This is an experimental follow-on to link to the Kotlin docs from the mdbook content and then run on CI and deploy all together. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-28T20:18:24Z 2019-05-30T14:49:06Z 2019-05-30T14:49:06Z 2019-05-30T14:49:06Z b5c24899bd92c377780e82d2ddbf3c6af99a778c     0 9aa39f80e952810bb3857ec939c87878ceb758d2 93736f8598b607f77c96bf9cda266c7716dde987 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/101    
283153204 MDExOlB1bGxSZXF1ZXN0MjgzMTUzMjA0 102 closed 0 Implement the DatetimeMetricType Dexterp37 883721 This implements the full stack for the `datetime` metric: from the Rust implementation to the Kotlin platform specific code. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T08:43:34Z 2019-06-04T12:35:47Z 2019-06-04T09:56:53Z 2019-06-04T09:56:53Z c96af194a24759b741148b4b179e6d9b30e2b63a     0 f4cd00d5bb5df52abe7caa8252bee78408d9c22d 232eab55e97d01bb6df8cc242192a1b232392486 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/102    
283266277 MDExOlB1bGxSZXF1ZXN0MjgzMjY2Mjc3 103 closed 0 Remove unused dependencies badboy 2129 These are currently not used anywhere and can be removed. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T13:40:03Z 2019-05-29T15:40:15Z 2019-05-29T15:40:11Z 2019-05-29T15:40:11Z 93736f8598b607f77c96bf9cda266c7716dde987     0 0b50b10d362dccf47c8d961e0f02a987aa457d6f f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/103    
283268131 MDExOlB1bGxSZXF1ZXN0MjgzMjY4MTMx 104 closed 0 Fetch seen labels from the database badboy 2129 This goes through the database and looks for all stored data for the named labeled metric and extracts the labels. I thought about extracting the extraction part into a function but couldn't come up with a proper name for it. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T13:44:09Z 2019-06-04T11:32:13Z 2019-06-04T11:31:34Z 2019-06-04T11:31:34Z af8db2f1257014044eecd8c8381fadd4244afecc     0 4e0ba1686815005bb16ea2299c89de871b5df5ec c96af194a24759b741148b4b179e6d9b30e2b63a MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/104    
283272868 MDExOlB1bGxSZXF1ZXN0MjgzMjcyODY4 105 closed 0 Add codeowners badboy 2129 It's simple: for now it's all 3 of us for everything. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T13:54:36Z 2019-05-29T14:30:28Z 2019-05-29T14:30:26Z 2019-05-29T14:30:26Z 2082ac2e90cec289e72a83a5d28b8d382a190c5b     0 294078710aa64b463dcdf922b3842c5725c21b22 f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/105    
283287134 MDExOlB1bGxSZXF1ZXN0MjgzMjg3MTM0 106 closed 0 Reinstate deep JSON inspection of labeled metric tests mdboom 38294 This brings back in some testing content from glean-ac in LabeledMetricTypeTests.kt. Mainly, this checks pings against the schema, since getting that right for labeled metrics is a bit fiddly. In order to do this, it makes `collectAndCheckPingSchema` from glean-ac work and updates the API to use `PingType` rather than ping names. This had knockon effects in the FFI, and then the C FFI example, so that's been updated to run on Linux and also run in CI. **I plan to go back and make that work on Mac as well again, once I've verified CI is working on that.** ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T14:25:12Z 2020-04-14T19:09:27Z 2019-05-29T15:37:36Z 2019-05-29T15:37:36Z 6673bdfd6d5cca9d58f1fc34caedf65f6e4c7f61     0 374404375c3898ca1e3f72e4f5d5f50b09254710 2082ac2e90cec289e72a83a5d28b8d382a190c5b CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/106    
283383114 MDExOlB1bGxSZXF1ZXN0MjgzMzgzMTE0 107 closed 0 1554275: Port PingMakerTests.kt to the rust side mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-29T18:36:54Z 2020-04-14T19:09:34Z 2019-06-03T20:08:21Z 2019-06-03T20:08:21Z 7470f7edba3daffea637d5084d134d09c26a3ba9     0 c0dd522cd6f290317f5f306094e6941c2f6f0bc8 c7841592feee355ad04b4f569ec931ab7ad789ec CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/107    
283699423 MDExOlB1bGxSZXF1ZXN0MjgzNjk5NDIz 108 closed 0 Fix Kotlin doc deployment mdboom 38294 Persisting the docs in two different tasks and then merging for deployment didn't work as I had hoped, so I'm trying something different. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-30T15:26:42Z 2020-04-14T19:09:25Z 2019-05-30T16:19:32Z 2019-05-30T16:19:32Z 98cadefe621fe2f9cc51ee517718a2e5b7fa792f     0 eed9e2198ecb7ab4da0a71cf0c6ccf06961b3556 b5c24899bd92c377780e82d2ddbf3c6af99a778c CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/108    
283727434 MDExOlB1bGxSZXF1ZXN0MjgzNzI3NDM0 109 closed 0 Revert "Fix Kotlin doc deployment" mdboom 38294 Reverts mozilla/glean#108 2019-05-30T16:45:19Z 2019-07-10T16:33:04Z 2019-05-30T16:45:30Z 2019-05-30T16:45:30Z 20170b48207af3f26d5dc8a1df858b5f1d67ca20     0 06f00b58f53eed88ebbac59c76f5fb83ca8f7e0c 98cadefe621fe2f9cc51ee517718a2e5b7fa792f CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/109    
283743977 MDExOlB1bGxSZXF1ZXN0MjgzNzQzOTc3 110 closed 0 Fix Kotlin doc deploy mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-30T17:34:38Z 2019-05-30T18:35:27Z 2019-05-30T18:35:26Z 2019-05-30T18:35:26Z ad30c9f7f2832e8a466bc59414706c8721f1be0c     0 dab371d30c2a58c36f3fbdf917fd20960e3c3eba 20170b48207af3f26d5dc8a1df858b5f1d67ca20 CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/110    
283767053 MDExOlB1bGxSZXF1ZXN0MjgzNzY3MDUz 111 closed 0 Hardcode project name in Kotlin doc generation mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-30T18:43:40Z 2020-04-14T19:09:16Z 2019-05-30T18:43:53Z 2019-05-30T18:43:53Z b3c4fb9540bb08096516b98498165cf2216ab73f     0 71748cc76a9a6243d9b262ee102ca8c6e4fdb400 ad30c9f7f2832e8a466bc59414706c8721f1be0c CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/111    
283944943 MDExOlB1bGxSZXF1ZXN0MjgzOTQ0OTQz 112 closed 0 Upgrade the WorkManager dependency to 2.0.1 Dexterp37 883721 This fixes a crash occurring in glean when the connectivity is disabled and then enabled. See https://github.com/mozilla-mobile/android-components/issues/3110 for context. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-05-31T08:16:47Z 2019-05-31T13:03:49Z 2019-05-31T13:03:48Z 2019-05-31T13:03:48Z c7841592feee355ad04b4f569ec931ab7ad789ec Dexterp37 883721   0 30eab65768827ab481f63bc0acb8ae91fb7ec807 b3c4fb9540bb08096516b98498165cf2216ab73f MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/112    
284101851 MDExOlB1bGxSZXF1ZXN0Mjg0MTAxODUx 113 closed 0 1555975: Move markdown docs from glean-ac to glean-core mdboom 38294 This moves all of the doc content in glean-ac in markdown (i.e. not docstrings) over to glean-core -- specifically, this is everything in `components/service/glean/docs` as well as `components/service/glean/README.md`, but reorganized into smaller chunks. I tried to update things that have changed, but not much has since we're keeping the same public API. For the documentation of the specific metric types, I tried to split the difference between the "narrative" style in glean-ac and the systematic style with standard headers that @badboy started over here. I basically added a `Configuration` section (talking about metrics.yaml content), an `API` section talking about using the metric and a `Reference` section linking to the javadoc. It's clear from this that eventually we'll need a way to handle documenting Kotlin, Swift, Rust and beyond -- maybe [something like this](https://json-schema.org/understanding-json-schema/conventions.html#language-specific-notes) -- but for now, this is all completely Kotlin/Android-specific. This adds a linkchecking step to CI -- I found it really helpful as I was moving pieces around from other repos to automate the process of making sure internal links go somewhere. I considered using [mdbook-linkcheck](https://github.com/Michael-F-Bryan/mdbook-linkcheck) for this, but that doesn't deal with the fact that we have docs generated from 3 sources: mdbook, rustdoc and dokka. Instead, I'm using the pretty old and slow but popular "linkchecker" tool, mainly just because it has a Debian package. **NOTE**: This is only checking internal links. Checking external links is much slower, and there's a lot of false positives to things in the generated docs that we can't control. This also had me looking at the Kotlin docs and noting that some things should be private but aren't. Sorry if that's kind of out-of-scope -- happy to separate that out to another PR. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This … 2019-05-31T15:52:41Z 2020-04-14T19:09:31Z 2019-06-05T12:02:13Z 2019-06-05T12:02:13Z 25b97d6ccfc8107a743d687363f3a2a301cd28ed     0 975e2a14322fea83bc0060f38735cc02614a3b3a b9379f2d8036fd22021b1df1666087918898e84f CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/113    
284601285 MDExOlB1bGxSZXF1ZXN0Mjg0NjAxMjg1 114 closed 0 Store an instance of the underlying metric and clone it on request badboy 2129 This has the overhead of storing a metric instance per labeled metric. However, these should be rather small. And on the upside this allows us to store metric-type-specific data (e.g. the time unit for DateTime) for that metric only instead of inside the common metric data. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-06-03T14:53:05Z 2019-06-04T10:22:04Z 2019-06-04T08:27:04Z 2019-06-04T08:27:04Z 232eab55e97d01bb6df8cc242192a1b232392486     0 c1c51aa5e590b35b873c00b388de13fcd1bc29ba c7841592feee355ad04b4f569ec931ab7ad789ec MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/114    
284717680 MDExOlB1bGxSZXF1ZXN0Mjg0NzE3Njgw 115 closed 0 Small copypasta fix to contribution docs. chutten 1123376 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-06-03T20:26:24Z 2019-06-03T20:35:11Z 2019-06-03T20:35:11Z 2019-06-03T20:35:11Z 96cef895fa0945c1583792f4b7307311abe22291     0 acd4de608712e934e942e01dc12a079a1af21012 7470f7edba3daffea637d5084d134d09c26a3ba9 MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/115    
284902490 MDExOlB1bGxSZXF1ZXN0Mjg0OTAyNDkw 116 closed 0 Bump the string length limit to 100 characters to match glean-ac Dexterp37 883721 This is about to land in glean-ac too. Let's not merge it until mozilla-mobile/android-components#3236 is merged. ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-06-04T10:06:29Z 2019-06-04T12:40:58Z 2019-06-04T12:40:58Z 2019-06-04T12:40:58Z b9379f2d8036fd22021b1df1666087918898e84f     0 a2118c49f61bce0af7bc1849e11685c8e28bd039 c96af194a24759b741148b4b179e6d9b30e2b63a MEMBER   glean 160544457 https://github.com/mozilla/glean/pull/116    
285096042 MDExOlB1bGxSZXF1ZXN0Mjg1MDk2MDQy 117 closed 0 1552842: Document how to run tests mdboom 38294 ### Pull Request checklist ### <!-- Before submitting the PR, please address each item --> - [ ] **Quality**: This PR builds and tests run cleanly - `make test` runs without emitting any warnings - `make lint` runs without emitting any errors - [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not - [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one - Any breaking changes to language binding APIs are noted explicitly 2019-06-04T18:41:32Z 2020-04-14T19:09:09Z 2019-06-05T13:36:53Z 2019-06-05T13:36:53Z 57c6e83d6d0ace2e0bfd2bb6f6d9662222b45152     0 23ce9c0633ee23a6ae85b23b65c5e2400b2d059a 25b97d6ccfc8107a743d687363f3a2a301cd28ed CONTRIBUTOR   glean 160544457 https://github.com/mozilla/glean/pull/117    

Next page

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [pull_requests] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [state] TEXT,
   [locked] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [body] TEXT,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [merged_at] TEXT,
   [merge_commit_sha] TEXT,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [draft] INTEGER,
   [head] TEXT,
   [base] TEXT,
   [author_association] TEXT,
   [auto_merge] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [url] TEXT,
   [merged_by] INTEGER REFERENCES [users]([id])
, [stack] TEXT);
CREATE INDEX [idx_pull_requests_merged_by]
    ON [pull_requests] ([merged_by]);
CREATE INDEX [idx_pull_requests_repo]
    ON [pull_requests] ([repo]);
CREATE INDEX [idx_pull_requests_milestone]
    ON [pull_requests] ([milestone]);
CREATE INDEX [idx_pull_requests_assignee]
    ON [pull_requests] ([assignee]);
CREATE INDEX [idx_pull_requests_user]
    ON [pull_requests] ([user]);
Powered by Datasette · Queries took 511.212ms