{"database": "github", "table": "pull_requests", "is_view": false, "human_description_en": "", "rows": [{"id": 263236200, "node_id": "MDExOlB1bGxSZXF1ZXN0MjYzMjM2MjAw", "number": 1, "state": "closed", "locked": 0, "title": "Add CircleCI configuration with doc generation & deployment", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-03-21T13:32:03Z", "updated_at": "2019-03-21T13:39:45Z", "closed_at": "2019-03-21T13:39:43Z", "merged_at": "2019-03-21T13:39:43Z", "merge_commit_sha": "736f20a187c127ed24008a4d2fc00213864d2e56", "assignee": null, "milestone": null, "draft": 0, "head": "0bcde3668e059a20cb8db8e3cdd8dcf68aacde5a", "base": "e9fa3c355f8840d5310c9f409ab082bb7a37ba04", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/1", "merged_by": null, "stack": null}, {"id": 263239226, "node_id": "MDExOlB1bGxSZXF1ZXN0MjYzMjM5MjI2", "number": 2, "state": "closed", "locked": 0, "title": "Setup iOS project", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-03-21T13:40:24Z", "updated_at": "2019-03-27T19:04:21Z", "closed_at": "2019-03-27T19:04:04Z", "merged_at": "2019-03-27T19:04:04Z", "merge_commit_sha": "a6923c6a0f48f4d26f763db53da71639df5aa7f6", "assignee": null, "milestone": null, "draft": 0, "head": "93c0885342c3e981aac846f2026ba74e5d83fdaf", "base": "59a6b1b06b761b677a8ecea1946653c4a1f06f8f", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/2", "merged_by": null, "stack": null}, {"id": 263632932, "node_id": "MDExOlB1bGxSZXF1ZXN0MjYzNjMyOTMy", "number": 3, "state": "closed", "locked": 0, "title": "Setup Android project", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-03-22T14:25:50Z", "updated_at": "2019-03-27T17:49:02Z", "closed_at": "2019-03-27T17:47:21Z", "merged_at": "2019-03-27T17:47:21Z", "merge_commit_sha": "59a6b1b06b761b677a8ecea1946653c4a1f06f8f", "assignee": null, "milestone": null, "draft": 0, "head": "4b85c019a545d015e5dd6947b3c748c589cbf0d3", "base": "736f20a187c127ed24008a4d2fc00213864d2e56", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/3", "merged_by": null, "stack": null}, {"id": 266742116, "node_id": "MDExOlB1bGxSZXF1ZXN0MjY2NzQyMTE2", "number": 4, "state": "closed", "locked": 0, "title": "Branding is important", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-04-02T17:34:25Z", "updated_at": "2020-04-14T19:09:02Z", "closed_at": "2019-04-30T12:30:48Z", "merged_at": "2019-04-30T12:30:48Z", "merge_commit_sha": "cd31d715ac0107b23142f8282aee61fceb6d6da9", "assignee": null, "milestone": null, "draft": 0, "head": "bca2b27a563cda6d8ac8b8cdb44bb29782275ae1", "base": "b5a24bca9001274e67f037c6e7980a4251f68660", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/4", "merged_by": null, "stack": null}, {"id": 274711390, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc0NzExMzkw", "number": 5, "state": "closed", "locked": 0, "title": "With rkv", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-04-30T12:31:26Z", "updated_at": "2025-07-30T10:03:57Z", "closed_at": "2019-04-30T12:56:19Z", "merged_at": "2019-04-30T12:56:19Z", "merge_commit_sha": "0e87a6376a937d54aa88c50d8b190f6a8e6a027e", "assignee": null, "milestone": null, "draft": 0, "head": "7efed3ebacbae56e039a0eebb41cec1f1abb8b95", "base": "e2a7a0553f321bcd0ce4e48b029fc8bed4795080", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/5", "merged_by": null, "stack": null}, {"id": 276922192, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTIyMTky", "number": 6, "state": "closed", "locked": 0, "title": "Move the storage details to a separate module", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This PR moves the rkv implementation details, including Lifetime.Application handling, to\r\nthe newly introduced Database module.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [x] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T09:30:43Z", "updated_at": "2019-05-08T10:06:02Z", "closed_at": "2019-05-08T10:06:02Z", "merged_at": "2019-05-08T10:06:01Z", "merge_commit_sha": "388a44c0940e7ec49f11ed7b02ec69d6f49e7605", "assignee": null, "milestone": null, "draft": 0, "head": "b4dec7130462fbe3e81cdd667e0ff01aab44e9d9", "base": "45fa2efebb69c8680437fd74bdb6e542a8f15705", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/6", "merged_by": null, "stack": null}, {"id": 276925944, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTI1OTQ0", "number": 7, "state": "closed", "locked": 0, "title": "Store pings to disk", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T09:42:17Z", "updated_at": "2020-04-02T16:48:54Z", "closed_at": "2019-05-08T11:48:22Z", "merged_at": "2019-05-08T11:48:22Z", "merge_commit_sha": "523f76fa69a962b74ec4aae8cd998eef6d6877d6", "assignee": null, "milestone": null, "draft": 0, "head": "9742038465390b27c409292773dc2825b1ec1c7a", "base": "388a44c0940e7ec49f11ed7b02ec69d6f49e7605", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/7", "merged_by": null, "stack": null}, {"id": 276972068, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTcyMDY4", "number": 8, "state": "closed", "locked": 0, "title": "No more singleton", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T12:09:42Z", "updated_at": "2019-05-09T09:20:31Z", "closed_at": "2019-05-08T12:51:37Z", "merged_at": "2019-05-08T12:51:37Z", "merge_commit_sha": "ec6c604a58b078664cbd6179e9f0d06664cc3a9e", "assignee": null, "milestone": null, "draft": 0, "head": "5bbb46d2286ffb585c78a5e41cf105cf0ef0e217", "base": "523f76fa69a962b74ec4aae8cd998eef6d6877d6", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/8", "merged_by": null, "stack": null}, {"id": 276978409, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTc4NDA5", "number": 9, "state": "closed", "locked": 0, "title": "WIP: Validate jsonschema in integration tests", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T12:30:13Z", "updated_at": "2020-04-14T18:48:39Z", "closed_at": "2019-06-07T12:38:25Z", "merged_at": null, "merge_commit_sha": "cde1533425d6b0429730aa88108959d596b43f63", "assignee": null, "milestone": null, "draft": 0, "head": "d848e4f14ba5bff3e4a378543fba73fb1dfdba89", "base": "523f76fa69a962b74ec4aae8cd998eef6d6877d6", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/9", "merged_by": null, "stack": null}, {"id": 276985470, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTg1NDcw", "number": 12, "state": "closed", "locked": 0, "title": "Api playground", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T12:52:21Z", "updated_at": "2025-07-30T10:04:51Z", "closed_at": "2019-05-08T13:01:35Z", "merged_at": "2019-05-08T13:01:35Z", "merge_commit_sha": "fb44796fe856fee7fdf96b0a0f774be51685f411", "assignee": null, "milestone": null, "draft": 0, "head": "ec6c604a58b078664cbd6179e9f0d06664cc3a9e", "base": "565cc7b773e6a363c65cff66e298e4d2c4d37488", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/12", "merged_by": null, "stack": null}, {"id": 276993821, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc2OTkzODIx", "number": 13, "state": "closed", "locked": 0, "title": "Pass around the object to access its state", "user": {"value": 2129, "label": "badboy"}, "body": "Fixes #11\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T13:16:45Z", "updated_at": "2019-05-08T15:22:47Z", "closed_at": "2019-05-08T14:01:36Z", "merged_at": "2019-05-08T14:01:36Z", "merge_commit_sha": "48e06ed73c84a2a07c6e3696e8d01342ac22d850", "assignee": null, "milestone": null, "draft": 0, "head": "094390e7030f402be0f8b60caca3b6d98f3a1b2c", "base": "fb44796fe856fee7fdf96b0a0f774be51685f411", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/13", "merged_by": null, "stack": null}, {"id": 277053758, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3MDUzNzU4", "number": 15, "state": "closed", "locked": 0, "title": "Implement API to get the value back from a metric", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T15:50:37Z", "updated_at": "2019-05-09T09:56:35Z", "closed_at": "2019-05-09T09:56:31Z", "merged_at": "2019-05-09T09:56:31Z", "merge_commit_sha": "d2fe269045a1a5657db6379043f784edc04c0763", "assignee": null, "milestone": null, "draft": 0, "head": "4cce42c48fb2e47f1c15dcb8fa3db4ee1078e099", "base": "48e06ed73c84a2a07c6e3696e8d01342ac22d850", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/15", "merged_by": null, "stack": null}, {"id": 277053886, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3MDUzODg2", "number": 16, "state": "closed", "locked": 0, "title": "Add test coverage for Database record", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This additionally moves some Database specific\r\ndetail (i.e. storage names formatted as \"{}#\")\r\nback to the Database.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-08T15:51:00Z", "updated_at": "2019-05-09T10:10:03Z", "closed_at": "2019-05-09T10:10:02Z", "merged_at": "2019-05-09T10:10:02Z", "merge_commit_sha": "3a21db06bffad72bba2048039f4ecdec7bb59120", "assignee": null, "milestone": null, "draft": 0, "head": "0158649be04c434ad830ade8e43e7da9884e3945", "base": "d2fe269045a1a5657db6379043f784edc04c0763", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/16", "merged_by": null, "stack": null}, {"id": 277297615, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3Mjk3NjE1", "number": 17, "state": "closed", "locked": 0, "title": "Add simple Kotlin test", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T08:34:49Z", "updated_at": "2020-04-14T19:09:02Z", "closed_at": "2019-05-09T11:15:17Z", "merged_at": "2019-05-09T11:15:17Z", "merge_commit_sha": "66e39a524a20688c6016743c420ad2743cc15c6c", "assignee": null, "milestone": null, "draft": 0, "head": "6672f1ee1baf3e43d150ee8d5164ad43c51d4762", "base": "3a21db06bffad72bba2048039f4ecdec7bb59120", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/17", "merged_by": null, "stack": null}, {"id": 277374672, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3Mzc0Njcy", "number": 18, "state": "closed", "locked": 0, "title": "Pass meta data", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T12:37:33Z", "updated_at": "2019-05-09T13:13:21Z", "closed_at": "2019-05-09T13:03:53Z", "merged_at": "2019-05-09T13:03:53Z", "merge_commit_sha": "c99ce4ba0a9ef8b6cffefb7538b495d7c8a053a7", "assignee": null, "milestone": null, "draft": 0, "head": "1117181c7d17f316a6ebb68d7542c76c6f73facd", "base": "66e39a524a20688c6016743c420ad2743cc15c6c", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/18", "merged_by": null, "stack": null}, {"id": 277382560, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3MzgyNTYw", "number": 20, "state": "closed", "locked": 0, "title": "Introduce automatic metrics generation", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T13:01:20Z", "updated_at": "2019-05-09T13:40:27Z", "closed_at": "2019-05-09T13:40:27Z", "merged_at": "2019-05-09T13:40:27Z", "merge_commit_sha": "bf0a58ddce0dc629ce1e5b7af2dc46244b28190a", "assignee": null, "milestone": null, "draft": 0, "head": "2ef559b53df9a5acadc3f67bd5fe4e4c0b2943a7", "base": "c99ce4ba0a9ef8b6cffefb7538b495d7c8a053a7", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/20", "merged_by": null, "stack": null}, {"id": 277387929, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3Mzg3OTI5", "number": 21, "state": "closed", "locked": 0, "title": "Don't handle the array when getting a null pointer", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T13:16:20Z", "updated_at": "2019-05-09T13:52:50Z", "closed_at": "2019-05-09T13:49:36Z", "merged_at": "2019-05-09T13:49:36Z", "merge_commit_sha": "474848394cd2ad3e5dc1192f797ef589ea713779", "assignee": null, "milestone": null, "draft": 0, "head": "a95af6bb2ab694e980af16547cf9d9ba7ee1244f", "base": "bf0a58ddce0dc629ce1e5b7af2dc46244b28190a", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/21", "merged_by": null, "stack": null}, {"id": 277402597, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDAyNTk3", "number": 22, "state": "closed", "locked": 0, "title": "Add handleBackgroundEvent", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T13:54:29Z", "updated_at": "2020-04-14T19:09:22Z", "closed_at": "2019-05-09T14:24:46Z", "merged_at": "2019-05-09T14:24:46Z", "merge_commit_sha": "701549c96baedc1300585207f5b9e8261620353e", "assignee": null, "milestone": null, "draft": 0, "head": "061a4e8a47ef3e6244bcfcd228c63510725748f0", "base": "474848394cd2ad3e5dc1192f797ef589ea713779", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/22", "merged_by": null, "stack": null}, {"id": 277414180, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDE0MTgw", "number": 23, "state": "closed", "locked": 0, "title": "Add a few core metrics", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T14:23:47Z", "updated_at": "2019-05-09T14:42:08Z", "closed_at": "2019-05-09T14:42:08Z", "merged_at": "2019-05-09T14:42:08Z", "merge_commit_sha": "6553128441748dcbe5788f2cee913aa78417e9de", "assignee": null, "milestone": null, "draft": 0, "head": "291030c44bdf2be4d059b53e79cf96375d60eba2", "base": "474848394cd2ad3e5dc1192f797ef589ea713779", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/23", "merged_by": null, "stack": null}, {"id": 277415312, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDE1MzEy", "number": 24, "state": "closed", "locked": 0, "title": "Sample generate", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T14:26:30Z", "updated_at": "2019-05-09T14:59:22Z", "closed_at": "2019-05-09T14:56:04Z", "merged_at": "2019-05-09T14:56:04Z", "merge_commit_sha": "128224e554d512c159ccef7c155062f8a1c6977d", "assignee": null, "milestone": null, "draft": 0, "head": "047ba7a4c480819eb98a9b9e8362ed248f5c38c0", "base": "701549c96baedc1300585207f5b9e8261620353e", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/24", "merged_by": null, "stack": null}, {"id": 277415382, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDE1Mzgy", "number": 25, "state": "closed", "locked": 0, "title": "Make use of test API", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T14:26:42Z", "updated_at": "2019-05-09T14:59:37Z", "closed_at": "2019-05-09T14:58:48Z", "merged_at": "2019-05-09T14:58:48Z", "merge_commit_sha": "5e48c9e1f9500f55d4ba804ecbb6a394ab9fe20f", "assignee": null, "milestone": null, "draft": 0, "head": "d074af41f3dfe2dff36bc456a3bafcee8d15add4", "base": "701549c96baedc1300585207f5b9e8261620353e", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/25", "merged_by": null, "stack": null}, {"id": 277427651, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDI3NjUx", "number": 27, "state": "closed", "locked": 0, "title": "Expose test api", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T14:56:19Z", "updated_at": "2019-05-09T15:00:17Z", "closed_at": "2019-05-09T15:00:10Z", "merged_at": "2019-05-09T15:00:10Z", "merge_commit_sha": "b22ab8be19164fcfe3fc446a098de14767bd26bf", "assignee": null, "milestone": null, "draft": 0, "head": "4c14c3c45973e25ddcd9f27f92692c3397cbf971", "base": "128224e554d512c159ccef7c155062f8a1c6977d", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/27", "merged_by": null, "stack": null}, {"id": 277439946, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDM5OTQ2", "number": 37, "state": "closed", "locked": 0, "title": "Send a ping from the button", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T15:27:39Z", "updated_at": "2020-04-14T19:09:23Z", "closed_at": "2019-05-09T15:32:00Z", "merged_at": "2019-05-09T15:32:00Z", "merge_commit_sha": "e63c63e8bed640a312ec9fea13087d910c1ea512", "assignee": null, "milestone": null, "draft": 0, "head": "a3fc0fb56fa5308eb30c16598839b94c2a3aefdd", "base": "b22ab8be19164fcfe3fc446a098de14767bd26bf", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/37", "merged_by": null, "stack": null}, {"id": 277447006, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDQ3MDA2", "number": 38, "state": "closed", "locked": 0, "title": "Add smoke values for common fields to make valid pings", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T15:45:32Z", "updated_at": "2019-05-09T15:53:02Z", "closed_at": "2019-05-09T15:53:02Z", "merged_at": "2019-05-09T15:53:02Z", "merge_commit_sha": "b9e7a144e011087bf9a35edaf4b1a136b34d429b", "assignee": null, "milestone": null, "draft": 0, "head": "db693d720226952f3881672e95519667e15c7de8", "base": "e63c63e8bed640a312ec9fea13087d910c1ea512", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/38", "merged_by": null, "stack": null}, {"id": 277460673, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NDYwNjcz", "number": 40, "state": "closed", "locked": 0, "title": "Include android resources when running tests", "user": {"value": 2129, "label": "badboy"}, "body": "This ... seems to fix the build issues.\r\n\r\nFixes #39\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-09T16:23:28Z", "updated_at": "2019-05-09T16:25:29Z", "closed_at": "2019-05-09T16:25:24Z", "merged_at": "2019-05-09T16:25:24Z", "merge_commit_sha": "ca6ffdcde5b09f13ce9363ecdfb51772c7a9298a", "assignee": null, "milestone": null, "draft": 0, "head": "2bd57b6c6031208f98aab1bbe48bbbf9d1310299", "base": "b9e7a144e011087bf9a35edaf4b1a136b34d429b", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/40", "merged_by": null, "stack": null}, {"id": 277681286, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NjgxMjg2", "number": 41, "state": "closed", "locked": 0, "title": "Import test coverage from Glean-legacy for Counters and Strings", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-10T08:41:08Z", "updated_at": "2019-05-10T11:56:41Z", "closed_at": "2019-05-10T11:56:41Z", "merged_at": "2019-05-10T11:56:40Z", "merge_commit_sha": "46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b", "assignee": null, "milestone": null, "draft": 0, "head": "202ee528a27d9d3a831ba88f5a87310d2a27e9fe", "base": "139fdd72efbeecd9c22ec1e0749e2ee4eaa920bf", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/41", "merged_by": null, "stack": null}, {"id": 277682137, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NjgyMTM3", "number": 42, "state": "closed", "locked": 0, "title": "Enable gradle tests on CI ", "user": {"value": 2129, "label": "badboy"}, "body": "Fixes #34", "created_at": "2019-05-10T08:43:54Z", "updated_at": "2019-05-10T08:51:39Z", "closed_at": "2019-05-10T08:50:17Z", "merged_at": "2019-05-10T08:50:17Z", "merge_commit_sha": "1394f43e8bcc5b1c54df24a8a69cfff01da15378", "assignee": null, "milestone": null, "draft": 0, "head": "a4087602a331f878640ae03d5e4fd077e3533a51", "base": "ca6ffdcde5b09f13ce9363ecdfb51772c7a9298a", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/42", "merged_by": null, "stack": null}, {"id": 277692131, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3NjkyMTMx", "number": 44, "state": "closed", "locked": 0, "title": "Install mdbook from released binary", "user": {"value": 2129, "label": "badboy"}, "body": "This should speed up documentation generation by a bit.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-10T09:14:54Z", "updated_at": "2019-05-10T15:07:30Z", "closed_at": "2019-05-10T09:46:53Z", "merged_at": "2019-05-10T09:46:53Z", "merge_commit_sha": "b9c234e02a1b00ac195d96776212a97b16e6d0f4", "assignee": null, "milestone": null, "draft": 0, "head": "106dd6a73b1d576203a3e86557290985302a73be", "base": "1394f43e8bcc5b1c54df24a8a69cfff01da15378", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/44", "merged_by": null, "stack": null}, {"id": 277697390, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3Njk3Mzkw", "number": 45, "state": "closed", "locked": 0, "title": "Be more dynamic in use of glean_parser", "user": {"value": 38294, "label": "mdboom"}, "body": "This moves the `sdk_generator.gradle` file back to something that could be more easily shared between legacy glean and glean.rs by adding config variables for the things that need to be different.\r\n\r\nAlso, this will no longer download glean_parser on every build.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-10T09:30:11Z", "updated_at": "2020-04-14T19:09:21Z", "closed_at": "2019-05-10T10:09:37Z", "merged_at": "2019-05-10T10:09:37Z", "merge_commit_sha": "139fdd72efbeecd9c22ec1e0749e2ee4eaa920bf", "assignee": null, "milestone": null, "draft": 0, "head": "d2a3e5ce3ee452ecbbf284fbb639825624c350da", "base": "1394f43e8bcc5b1c54df24a8a69cfff01da15378", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/45", "merged_by": null, "stack": null}, {"id": 277810056, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc3ODEwMDU2", "number": 47, "state": "closed", "locked": 0, "title": "WIP: Use a counter for the sequence number per ping", "user": {"value": 2129, "label": "badboy"}, "body": "This mis-uses our test-only API right now to get back the value and\r\nencodes the ping name into the key.\r\n\r\nNOT READY TO BE MERGED!", "created_at": "2019-05-10T15:16:02Z", "updated_at": "2019-07-10T16:33:16Z", "closed_at": "2019-06-05T09:05:09Z", "merged_at": null, "merge_commit_sha": "f2dbae03e6e045743c493024f91a8b90aa68204e", "assignee": null, "milestone": null, "draft": 0, "head": "d1d9a077d1581ef062650bfe935e8dc7e9ffd039", "base": "46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/47", "merged_by": null, "stack": null}, {"id": 278184142, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MTg0MTQy", "number": 48, "state": "closed", "locked": 0, "title": "Update the developer setup notes", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-13T09:07:07Z", "updated_at": "2019-05-13T09:38:24Z", "closed_at": "2019-05-13T09:38:24Z", "merged_at": "2019-05-13T09:38:24Z", "merge_commit_sha": "4f6159c10b91bd2ee17f4c521b15311f58ee9014", "assignee": null, "milestone": null, "draft": 0, "head": "08224a823f149229a20eb8671c6f20072e1c3b23", "base": "46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/48", "merged_by": null, "stack": null}, {"id": 278187324, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MTg3MzI0", "number": 49, "state": "closed", "locked": 0, "title": "Add the MPL 2.0 license header to all the source code files", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This closes #28 .\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-13T09:16:00Z", "updated_at": "2019-05-13T09:22:27Z", "closed_at": "2019-05-13T09:22:27Z", "merged_at": "2019-05-13T09:22:27Z", "merge_commit_sha": "d2fe97cdf6ca2896dfd4f3d50b48ab5199db6c90", "assignee": null, "milestone": null, "draft": 0, "head": "d1e9a454661e1d1e3b49e7689a4083245176d1cf", "base": "46c8aac1d7e07356aa3a4c5c2e5f5d705ea6515b", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/49", "merged_by": null, "stack": null}, {"id": 278235759, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MjM1NzU5", "number": 50, "state": "closed", "locked": 0, "title": "Disclaimer", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-13T11:38:47Z", "updated_at": "2019-05-13T14:46:34Z", "closed_at": "2019-05-13T13:28:16Z", "merged_at": "2019-05-13T13:28:16Z", "merge_commit_sha": "e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb", "assignee": null, "milestone": null, "draft": 0, "head": "32ff39b644134baf16f362913f8452649c2c2c90", "base": "4f6159c10b91bd2ee17f4c521b15311f58ee9014", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/50", "merged_by": null, "stack": null}, {"id": 278238857, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MjM4ODU3", "number": 51, "state": "closed", "locked": 0, "title": "Initialize objects on creation", "user": {"value": 2129, "label": "badboy"}, "body": "Fixes #29\r\n\r\nThis is in preparation of the [error handling](https://bugzilla.mozilla.org/show_bug.cgi?id=1551141) so that I don't have to touch these parts again.\t", "created_at": "2019-05-13T11:48:46Z", "updated_at": "2019-05-13T15:02:35Z", "closed_at": "2019-05-13T13:28:03Z", "merged_at": "2019-05-13T13:28:03Z", "merge_commit_sha": "fae652593c1d3a74df76898fc6407635cfe5fd8d", "assignee": null, "milestone": null, "draft": 0, "head": "df83047d0fa0696a534536a9ba7d7421d543c192", "base": "4f6159c10b91bd2ee17f4c521b15311f58ee9014", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/51", "merged_by": null, "stack": null}, {"id": 278256082, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MjU2MDgy", "number": 52, "state": "closed", "locked": 0, "title": "Generically handle error", "user": {"value": 2129, "label": "badboy"}, "body": "(Based on #51, that needs to be merged first)\r\n\r\nThis is a first try at removing most `.unwrap`s in the code.\r\nThere are some left, mostly in database operations, which should be done in a followup.\r\n\r\nThe way it works is it's always passing errors up until the FFI layer, where errors are logged and a potential default value for the FFI type is returned (e.g. a null pointer for pointers or 0 for the handle).\r\nThe Kotlin side needs to check these values (only relevant for glean object creation and metric constructor)\r\n\r\n(This also includes a couple of semi-related commits to update the generated C header and adding the license header where it was missing, hope that's not too distracting)", "created_at": "2019-05-13T12:40:45Z", "updated_at": "2019-05-15T07:54:53Z", "closed_at": "2019-05-15T07:54:48Z", "merged_at": "2019-05-15T07:54:48Z", "merge_commit_sha": "490bb816666d7b2703d83c3461028b75d05792e7", "assignee": null, "milestone": null, "draft": 0, "head": "ac30a91afe04bc3d0f29c7a005a0dfe461ba6864", "base": "d0c657239111995bc4fc804d617bfec5686b477f", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/52", "merged_by": null, "stack": null}, {"id": 278301369, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MzAxMzY5", "number": 53, "state": "closed", "locked": 0, "title": "Backport updates from application-services gradle files", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This applies the changes from [c40e2cc in mozilla/application-services](https://github.com/mozilla/application-services/tree/c40e2ccb422cf4af9ffdf095149cec34de1d4bef) to our repo, with minimal tweaks due to the different directory layout and the glean parsers integration.\r\n\r\n**Note** - klint and detekt are currently not invoked on CI, even though they can run manually, because we have dozens of errors :)\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-13T14:31:59Z", "updated_at": "2019-05-14T08:01:20Z", "closed_at": "2019-05-14T08:01:20Z", "merged_at": "2019-05-14T08:01:20Z", "merge_commit_sha": "19c1cf3dfe6ee4983b94e0ffca129e524144b229", "assignee": null, "milestone": null, "draft": 0, "head": "c2308caf3c9162d6db3954251759b9a1d2db75d4", "base": "e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/53", "merged_by": null, "stack": null}, {"id": 278302807, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4MzAyODA3", "number": 54, "state": "closed", "locked": 0, "title": "Enable parallel testing on CI", "user": {"value": 2129, "label": "badboy"}, "body": "Now that we've removed the singletons, this works\r\n\r\nFixes #33", "created_at": "2019-05-13T14:35:18Z", "updated_at": "2019-05-13T14:46:20Z", "closed_at": "2019-05-13T14:46:05Z", "merged_at": "2019-05-13T14:46:05Z", "merge_commit_sha": "2155cd1802673ec5368ba7c1f0af790176dd48bb", "assignee": null, "milestone": null, "draft": 0, "head": "2b8d38dd42c3586a1012c7c65e46b61dec6f645b", "base": "e51b4f707e5d5dfc126235bb7dcc9efc8101d3eb", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/54", "merged_by": null, "stack": null}, {"id": 278410267, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4NDEwMjY3", "number": 55, "state": "closed", "locked": 0, "title": "1551145: Copy over Kotlin simple public API tests", "user": {"value": 38294, "label": "mdboom"}, "body": "This is a first pass at moving over the Kotlin public API tests from glean-ac, and mocking out what needs to be in order to make them compile.\r\n\r\nThe things that aren't brought over (because they would require excessive mocking) are:\r\n\r\n- `TimingDistribution`\r\n- Labeled metrics\r\n- Error metrics\r\n\r\nPersonally, I'm most concerned about making sure our test coverage is easy to cross-reference against glean-ac, so I don't have a problem deferring those files for now, since it's clear by comparing against glean-ac that they are missing, and bringing them over once those features get fleshed out.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-13T19:49:02Z", "updated_at": "2020-04-14T19:09:32Z", "closed_at": "2019-05-14T13:18:53Z", "merged_at": "2019-05-14T13:18:53Z", "merge_commit_sha": "821cc6579854d81cfd44d4b23f455921f3f33d38", "assignee": null, "milestone": null, "draft": 0, "head": "8c560bb78121e7eed229c661fcf256b34cef7704", "base": "2155cd1802673ec5368ba7c1f0af790176dd48bb", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/55", "merged_by": null, "stack": null}, {"id": 278572579, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4NTcyNTc5", "number": 56, "state": "closed", "locked": 0, "title": "Add (empty) detekt config to make detekt happy", "user": {"value": 2129, "label": "badboy"}, "body": "`./gradlew detekt` didn't run for me without that file locally.\r\n\r\nHere's application-services file: https://github.com/mozilla/application-services/blob/377c1580deb21b9e17f8ba6d36e2565bab0891a5/.detekt.yml\r\n\r\nIt's 500 lines long. I don't like that and I don't understand roughly 499 of those lines, so I opted for having the most minimal working config instead.\r\n\r\nEdit: after more testing and chatting I removed the config file from the build.gradle. We can add it back when we _do_ need to change the config.", "created_at": "2019-05-14T08:29:02Z", "updated_at": "2019-07-10T16:33:47Z", "closed_at": "2019-05-14T09:34:19Z", "merged_at": "2019-05-14T09:34:19Z", "merge_commit_sha": "212b24ecd83b3495b18fdebb65cc16fe12db0b34", "assignee": null, "milestone": null, "draft": 0, "head": "684a990bfda16e36d6096c230d0227177d3b5ade", "base": "19c1cf3dfe6ee4983b94e0ffca129e524144b229", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/56", "merged_by": null, "stack": null}, {"id": 278668523, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4NjY4NTIz", "number": 57, "state": "closed", "locked": 0, "title": "Turn stateless PingMaker into free functions", "user": {"value": 2129, "label": "badboy"}, "body": "Fixes #31\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-14T12:52:38Z", "updated_at": "2019-08-16T09:22:56Z", "closed_at": "2019-05-14T14:49:58Z", "merged_at": null, "merge_commit_sha": "7dc9d6961b8ba85d1cfb094edb46a76840c63043", "assignee": null, "milestone": null, "draft": 0, "head": "ec71921240f9731d7f2a493fd5f7718ac9204e94", "base": "212b24ecd83b3495b18fdebb65cc16fe12db0b34", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/57", "merged_by": null, "stack": null}, {"id": 278668733, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4NjY4NzMz", "number": 58, "state": "closed", "locked": 0, "title": "Dont send pings if empty", "user": {"value": 2129, "label": "badboy"}, "body": "Based on #57 ", "created_at": "2019-05-14T12:53:11Z", "updated_at": "2019-05-15T13:19:55Z", "closed_at": "2019-05-15T13:19:52Z", "merged_at": "2019-05-15T13:19:52Z", "merge_commit_sha": "cc60dc80de4959533a1e670096db6de45f540e28", "assignee": null, "milestone": null, "draft": 0, "head": "c7983d46df5e4c5597f24eb0778c113e3916a074", "base": "955efe905d9034b3284388c541f1d600a84f0e46", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/58", "merged_by": null, "stack": null}, {"id": 278684649, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4Njg0NjQ5", "number": 59, "state": "closed", "locked": 0, "title": "1551258: Fix Kotlin linting and enable on CI", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-14T13:31:40Z", "updated_at": "2020-04-14T19:09:26Z", "closed_at": "2019-05-14T14:54:34Z", "merged_at": "2019-05-14T14:54:34Z", "merge_commit_sha": "d0c657239111995bc4fc804d617bfec5686b477f", "assignee": null, "milestone": null, "draft": 0, "head": "525f2be26c0a24b28a8410b1ec2cc27005e4b988", "base": "821cc6579854d81cfd44d4b23f455921f3f33d38", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/59", "merged_by": null, "stack": null}, {"id": 278837484, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4ODM3NDg0", "number": 60, "state": "closed", "locked": 0, "title": "1551153: Enable the ping uploader in glean-core", "user": {"value": 38294, "label": "mdboom"}, "body": "We have upload \\o/  (Well, mostly thanks to copying a bunch of already working code over from glean-ac -- thanks to @travis79 and @Dexterp37).\r\n\r\nThe first commit just copies the files from glean-ac over.  The second commit includes the changes to make them work in the new context.  So it might be easier to review by only looking at the second commit in order to ignore things that were already reviewed on the glean-ac side.\r\n\r\nThere are a few TODOs here, with bugs already created and noted.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-14T20:23:04Z", "updated_at": "2020-04-14T19:09:03Z", "closed_at": "2019-05-15T14:39:42Z", "merged_at": "2019-05-15T14:39:42Z", "merge_commit_sha": "2d6995a03d9c682e8c6ab1c45b58506cd150c4dc", "assignee": null, "milestone": null, "draft": 0, "head": "af4c3741cae19c8e493df20ad12dabe15cc31ca3", "base": "cc60dc80de4959533a1e670096db6de45f540e28", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/60", "merged_by": null, "stack": null}, {"id": 278861118, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc4ODYxMTE4", "number": 61, "state": "closed", "locked": 0, "title": "Use Android 27 docker image", "user": {"value": 38294, "label": "mdboom"}, "body": "The Android 27 SDK ends up getting downloaded by the build script.  Using the Docker image with that version already baked should save on CI runtime, theoretically, though we should confirm that before merging.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-14T21:36:45Z", "updated_at": "2020-04-02T16:47:23Z", "closed_at": "2019-05-15T08:04:05Z", "merged_at": "2019-05-15T08:04:05Z", "merge_commit_sha": "955efe905d9034b3284388c541f1d600a84f0e46", "assignee": null, "milestone": null, "draft": 0, "head": "06a03577884cf95952a804d242b0a1b185db6ba7", "base": "d0c657239111995bc4fc804d617bfec5686b477f", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/61", "merged_by": null, "stack": null}, {"id": 279000663, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MDAwNjYz", "number": 62, "state": "closed", "locked": 0, "title": "Update links and naming across the repository", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-05-15T09:00:18Z", "updated_at": "2019-07-10T16:33:11Z", "closed_at": "2019-05-15T12:12:29Z", "merged_at": "2019-05-15T12:12:29Z", "merge_commit_sha": "bd2abd819f76ff70ff2fe8754dc21c3cbe53cea0", "assignee": null, "milestone": null, "draft": 0, "head": "ce797e9191a038a1b7bbe494e528c83ff2dd6779", "base": "955efe905d9034b3284388c541f1d600a84f0e46", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/62", "merged_by": null, "stack": null}, {"id": 279043422, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MDQzNDIy", "number": 63, "state": "closed", "locked": 0, "title": "Expose an internal sync API and make the public API async", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-15T10:54:59Z", "updated_at": "2019-05-15T12:48:17Z", "closed_at": "2019-05-15T12:48:17Z", "merged_at": "2019-05-15T12:48:17Z", "merge_commit_sha": "24760b4bbb7b937f7ec11553e53ba077d01e30e9", "assignee": null, "milestone": null, "draft": 0, "head": "9c806ee1755077b1c6d71cefaa87c74f6b27d25a", "base": "955efe905d9034b3284388c541f1d600a84f0e46", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/63", "merged_by": null, "stack": null}, {"id": 279104894, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MTA0ODk0", "number": 64, "state": "closed", "locked": 0, "title": "Bug 1551863 - Pass missing disabled flag to Rust side", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-05-15T13:44:15Z", "updated_at": "2019-05-15T14:35:37Z", "closed_at": "2019-05-15T14:35:06Z", "merged_at": "2019-05-15T14:35:06Z", "merge_commit_sha": "3c663feb4620b67d127e71215aea7c0e365e9eb8", "assignee": null, "milestone": null, "draft": 0, "head": "fe47fdaabf65b7be69bf46655e1ef88164ac3dba", "base": "cc60dc80de4959533a1e670096db6de45f540e28", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/64", "merged_by": null, "stack": null}, {"id": 279147951, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MTQ3OTUx", "number": 65, "state": "closed", "locked": 0, "title": "Bug 1551892: Implement the testing API for the StringMetricType and enable the related tests", "user": {"value": 2129, "label": "badboy"}, "body": "", "created_at": "2019-05-15T15:21:46Z", "updated_at": "2019-05-16T07:25:39Z", "closed_at": "2019-05-16T07:25:35Z", "merged_at": "2019-05-16T07:25:35Z", "merge_commit_sha": "dbdeff47fd727688d3fda35ba1996335ac6c33c1", "assignee": null, "milestone": null, "draft": 0, "head": "a7a2a9c50ad2e6ea351c9c07f22fbaf52e4933f4", "base": "2d6995a03d9c682e8c6ab1c45b58506cd150c4dc", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/65", "merged_by": null, "stack": null}, {"id": 279201921, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MjAxOTIx", "number": 66, "state": "closed", "locked": 0, "title": "Update pull_request_template.md", "user": {"value": 38294, "label": "mdboom"}, "body": "This makes it more language-agnostic.\r\n\r\nI like using the `Makefile` for these conveniences, and I kind of like maintaining the Makefile indefinitely as a source of developer conveniences (as long is it doesn't become the \"real\" build tool).  But I don't know how well it works on Windows.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-15T17:54:13Z", "updated_at": "2020-04-02T16:49:55Z", "closed_at": "2019-05-16T15:37:33Z", "merged_at": "2019-05-16T15:37:33Z", "merge_commit_sha": "ccef0fd863560e4ca3555db7405ffd0528416d15", "assignee": null, "milestone": null, "draft": 0, "head": "d897aa400a71c50a42e7df4d1837aa4567d4c95f", "base": "2d6995a03d9c682e8c6ab1c45b58506cd150c4dc", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/66", "merged_by": null, "stack": null}, {"id": 279212992, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5MjEyOTky", "number": 67, "state": "closed", "locked": 0, "title": "1551692: Don't schedule the uploading worker if no ping queued", "user": {"value": 38294, "label": "mdboom"}, "body": "\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-15T18:28:22Z", "updated_at": "2020-04-14T19:09:10Z", "closed_at": "2019-05-16T22:07:22Z", "merged_at": "2019-05-16T22:07:22Z", "merge_commit_sha": "110e44584de68a960e92542903b0c3e093f3eaa4", "assignee": null, "milestone": null, "draft": 0, "head": "420f025ecd084fa59859b570dd7e1d700853b62e", "base": "ccef0fd863560e4ca3555db7405ffd0528416d15", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/67", "merged_by": null, "stack": null}, {"id": 279443377, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5NDQzMzc3", "number": 68, "state": "closed", "locked": 0, "title": "Add a Contact section to the readme file", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This also updates the bugzilla new bug template to add the expected priority and whiteboard tag so that bugs show up on bugzhub.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-16T10:29:07Z", "updated_at": "2020-06-05T09:06:00Z", "closed_at": "2019-05-16T10:38:52Z", "merged_at": "2019-05-16T10:38:52Z", "merge_commit_sha": "033f0550ead2fab04b3cb1a3853376e8e74dd2c9", "assignee": null, "milestone": null, "draft": 0, "head": "3ea524658762a069ba030b7de2cd4fd8563d5f77", "base": "dbdeff47fd727688d3fda35ba1996335ac6c33c1", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/68", "merged_by": null, "stack": null}, {"id": 279449077, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5NDQ5MDc3", "number": 69, "state": "closed", "locked": 0, "title": "Enable checking for Dispatcher's test mode in the test API", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-16T10:44:56Z", "updated_at": "2019-05-16T15:04:46Z", "closed_at": "2019-05-16T15:04:45Z", "merged_at": "2019-05-16T15:04:45Z", "merge_commit_sha": "1fbc891c55484fdac7e8f498a67af7f8ba42ee8c", "assignee": null, "milestone": null, "draft": 0, "head": "96d5fea88d3bfc1dabf5cfe4e3070ec6721dca75", "base": "435dbde0244584aece48a72fcb00982caab6152b", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/69", "merged_by": null, "stack": null}, {"id": 279475021, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5NDc1MDIx", "number": 70, "state": "closed", "locked": 0, "title": "Use i32 everywhere for counters", "user": {"value": 2129, "label": "badboy"}, "body": "We actually should use u32 internally, but:\r\nbecause Kotlin doesn't (yet) have unsigned integers, it's always going to pass us signed values.\r\nWe also do all the error checking on the Rust side, so we need to receive the signed value to check for negativity and bail out.\r\n\r\nWe still don't do overflow checks though.\r\n\r\n[Bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1552131)\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-16T12:04:02Z", "updated_at": "2019-05-16T12:49:24Z", "closed_at": "2019-05-16T12:48:56Z", "merged_at": "2019-05-16T12:48:56Z", "merge_commit_sha": "7681ddd65a5137895ec8a9a3c85ff20c3e2eea4c", "assignee": null, "milestone": null, "draft": 0, "head": "d3e4f01df7b807c4fc956e3ca396444b5816c4ac", "base": "033f0550ead2fab04b3cb1a3853376e8e74dd2c9", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/70", "merged_by": null, "stack": null}, {"id": 279475704, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5NDc1NzA0", "number": 71, "state": "closed", "locked": 0, "title": "Small edits on makefile", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `cargo clean; cargo test --all` runs without emitting any warnings\r\n  - `cargo fmt` does not produce any changes to the code\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to Swift or Kotlin binding APIs are noted explicitly\r\n", "created_at": "2019-05-16T12:06:03Z", "updated_at": "2019-05-16T15:11:55Z", "closed_at": "2019-05-16T14:11:31Z", "merged_at": "2019-05-16T14:11:31Z", "merge_commit_sha": "435dbde0244584aece48a72fcb00982caab6152b", "assignee": null, "milestone": null, "draft": 0, "head": "634f447dfb40be9ac78db6503bbfd8fbc537d9a3", "base": "033f0550ead2fab04b3cb1a3853376e8e74dd2c9", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/71", "merged_by": null, "stack": null}, {"id": 279651607, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5NjUxNjA3", "number": 72, "state": "closed", "locked": 0, "title": "1552122: Initial port (with some stubbing) of Glean core API", "user": {"value": 38294, "label": "mdboom"}, "body": "This moves over the public API on the Glean object.  I have also reorganized the other of the methods in `Glean.kt` so it matches glean-ac (which should make it easier to do line-by-line comparisons).\r\n\r\nAgain, the first commit is copying some files from glean-ac over verbatim.  The second commit then modifies them for our context.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-16T20:08:10Z", "updated_at": "2020-04-14T19:09:01Z", "closed_at": "2019-05-20T13:12:16Z", "merged_at": "2019-05-20T13:12:16Z", "merge_commit_sha": "dd5439695d70a1a4db57caff517763fa251fd533", "assignee": null, "milestone": null, "draft": 0, "head": "a9b1d59c0f2ae09a326dfae367bcffc5a16d13e9", "base": "b8dc19d966445050cb977e2dcf6636142eae3097", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/72", "merged_by": null, "stack": null}, {"id": 279864368, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5ODY0MzY4", "number": 73, "state": "closed", "locked": 0, "title": "1552474: Add a Byte.toBoolean convenience function", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-17T12:00:31Z", "updated_at": "2020-04-14T19:09:03Z", "closed_at": "2019-05-17T12:47:37Z", "merged_at": "2019-05-17T12:47:37Z", "merge_commit_sha": "b8dc19d966445050cb977e2dcf6636142eae3097", "assignee": null, "milestone": null, "draft": 0, "head": "51b87bfe16f26ca715c71e33a336661757f1f27b", "base": "110e44584de68a960e92542903b0c3e093f3eaa4", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/73", "merged_by": null, "stack": null}, {"id": 279887457, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjc5ODg3NDU3", "number": 74, "state": "closed", "locked": 0, "title": "Document how to add a new metric type in the code", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-17T13:13:52Z", "updated_at": "2019-05-20T13:46:52Z", "closed_at": "2019-05-20T13:28:57Z", "merged_at": "2019-05-20T13:28:57Z", "merge_commit_sha": "4403aa97f4c17fed1696373425478b67c69954e1", "assignee": null, "milestone": null, "draft": 0, "head": "d2aef2950382d067891a50553fa56af4aae0f8f6", "base": "b8dc19d966445050cb977e2dcf6636142eae3097", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/74", "merged_by": null, "stack": null}, {"id": 280006852, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwMDA2ODUy", "number": 75, "state": "closed", "locked": 0, "title": "1552136: Convert CounterStorageEngineTests.kt to Rust", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [x] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-17T19:29:35Z", "updated_at": "2020-04-02T16:47:29Z", "closed_at": "2019-05-20T16:17:35Z", "merged_at": "2019-05-20T16:17:35Z", "merge_commit_sha": "91db2ca80c3ab223e059eef99aed82bc8b9f8ce5", "assignee": null, "milestone": null, "draft": 0, "head": "bbc9036f2bb75e2fc7c204a7ab33754640111cbd", "base": "3b4ea95f6fde6823571e2c1572fabf8ef9a06c8a", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/75", "merged_by": null, "stack": null}, {"id": 280305862, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwMzA1ODYy", "number": 76, "state": "closed", "locked": 0, "title": "Default to a ping lifetime during conversion", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T09:19:44Z", "updated_at": "2019-05-20T13:13:48Z", "closed_at": "2019-05-20T13:13:17Z", "merged_at": "2019-05-20T13:13:17Z", "merge_commit_sha": "00033c3a957be5ed65eca611069586267698adf8", "assignee": null, "milestone": null, "draft": 0, "head": "2d936138b0780c0ffb26eb229834a89667d630a0", "base": "b8dc19d966445050cb977e2dcf6636142eae3097", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/76", "merged_by": null, "stack": null}, {"id": 280306728, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwMzA2NzI4", "number": 77, "state": "closed", "locked": 0, "title": "Bug 1552511 - Use finalizers to destruct metrics", "user": {"value": 2129, "label": "badboy"}, "body": "https://bugzilla.mozilla.org/show_bug.cgi?id=1552511\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T09:22:10Z", "updated_at": "2019-05-20T13:47:25Z", "closed_at": "2019-05-20T13:47:17Z", "merged_at": "2019-05-20T13:47:17Z", "merge_commit_sha": "bb9ead2256c87922db8eae9452debe902bb22087", "assignee": null, "milestone": null, "draft": 0, "head": "12ae60784c254944b22e6b28858f719e5db11c6f", "base": "b8dc19d966445050cb977e2dcf6636142eae3097", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/77", "merged_by": null, "stack": null}, {"id": 280383587, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwMzgzNTg3", "number": 78, "state": "closed", "locked": 0, "title": "Bug 1552820 - Expose boolean test API and re-enable metric tests", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T13:07:02Z", "updated_at": "2019-05-20T13:51:03Z", "closed_at": "2019-05-20T13:48:25Z", "merged_at": "2019-05-20T13:48:25Z", "merge_commit_sha": "a84711698cf744910f3c39107049cc8b191a56c7", "assignee": null, "milestone": null, "draft": 0, "head": "00a9020f4ec1bb4445ba423ec08fab0e58c02dff", "base": "b8dc19d966445050cb977e2dcf6636142eae3097", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/78", "merged_by": null, "stack": null}, {"id": 280390678, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwMzkwNjc4", "number": 79, "state": "closed", "locked": 0, "title": "Redirect logging to stdout in tests", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This enables a logger implementation on platforms that are not Android: we couldn't see any log beyond FFI for this reason, since tests are x86/x64.\r\n\r\nThis additionally redirects Kotlin logcat to stdout in tests.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T13:24:56Z", "updated_at": "2019-05-20T14:08:59Z", "closed_at": "2019-05-20T14:08:59Z", "merged_at": "2019-05-20T14:08:58Z", "merge_commit_sha": "3b4ea95f6fde6823571e2c1572fabf8ef9a06c8a", "assignee": null, "milestone": null, "draft": 0, "head": "666bfb01dded04c94d0793a3fcd861d0639a5ec4", "base": "00033c3a957be5ed65eca611069586267698adf8", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/79", "merged_by": null, "stack": null}, {"id": 280459239, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwNDU5MjM5", "number": 80, "state": "closed", "locked": 0, "title": "Bug 1552857 - Convert StringsStorageEngineTests.kt to Rust", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T16:19:55Z", "updated_at": "2019-05-21T07:21:54Z", "closed_at": "2019-05-21T07:20:43Z", "merged_at": "2019-05-21T07:20:43Z", "merge_commit_sha": "43d439c9a017b210d6fca9c45beb160a5fc2ccbe", "assignee": null, "milestone": null, "draft": 0, "head": "d0551bf8a95b194f186031ffc307726c2c6ac042", "base": "91db2ca80c3ab223e059eef99aed82bc8b9f8ce5", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/80", "merged_by": null, "stack": null}, {"id": 280537116, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwNTM3MTE2", "number": 81, "state": "closed", "locked": 0, "title": "1547967: Include pings metadata", "user": {"value": 38294, "label": "mdboom"}, "body": "This just copies over the updated `pings.yaml` from glean-ac and updates the glean_parser to a version that supports the new metadata.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-20T20:49:46Z", "updated_at": "2020-04-02T16:49:49Z", "closed_at": "2019-05-21T07:21:37Z", "merged_at": "2019-05-21T07:21:37Z", "merge_commit_sha": "3f04eb3242272207a3ca5557f65063a2f2e900ce", "assignee": null, "milestone": null, "draft": 0, "head": "cfcffdb4233d196775d1a9ecf030dbbbd7f2d5b4", "base": "91db2ca80c3ab223e059eef99aed82bc8b9f8ce5", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/81", "merged_by": null, "stack": null}, {"id": 280654393, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwNjU0Mzkz", "number": 82, "state": "closed", "locked": 0, "title": "Bug 1552860 - Convert BooleansStorageEngineTests.kt to Rust", "user": {"value": 2129, "label": "badboy"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-21T07:25:31Z", "updated_at": "2019-05-21T08:13:08Z", "closed_at": "2019-05-21T08:13:03Z", "merged_at": "2019-05-21T08:13:03Z", "merge_commit_sha": "5579f6ac78b071a31e66bb2a5bd9d86eabe255b7", "assignee": null, "milestone": null, "draft": 0, "head": "bd69a2a74a55dca1e51604957e4f364ec3164534", "base": "3f04eb3242272207a3ca5557f65063a2f2e900ce", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/82", "merged_by": null, "stack": null}, {"id": 280685529, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwNjg1NTI5", "number": 83, "state": "closed", "locked": 0, "title": "Merge the latest changes from a-s gradle scripts", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This enables back artifact publishing by integrating back the changes to the gradle scripts up until\r\nchangeset mozilla/application-services@5d8dd7b .\r\n\r\nThis allows to publish glean-core to a local Maven repo with the following command:\r\n\r\n`./gradlew publishToMavenLocal`\r\n\r\nOnce published, the package can be consumed by other applications built locally. Instructions on how to do that will come as part of [bug 1551156](https://bugzilla.mozilla.org/show_bug.cgi?id=1551156).\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-21T08:58:13Z", "updated_at": "2019-05-21T12:30:17Z", "closed_at": "2019-05-21T12:30:17Z", "merged_at": "2019-05-21T12:30:17Z", "merge_commit_sha": "4898bd0492278f3911afde21216c8b84ce1dd5f2", "assignee": null, "milestone": null, "draft": 0, "head": "ebea36d08c6d5f8fa105e84b0b7a99cfcc86ece3", "base": "5579f6ac78b071a31e66bb2a5bd9d86eabe255b7", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/83", "merged_by": null, "stack": null}, {"id": 280696831, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwNjk2ODMx", "number": 84, "state": "closed", "locked": 0, "title": "Bug 1552850 - Implement shouldRecord on the Kotlin side", "user": {"value": 2129, "label": "badboy"}, "body": "Posting this because the code part was easy, but I have some hesitations:\r\n\r\n* The `should_record` check _also_ happens on the Rust side\r\n\t* We do avoid putting any work in the Dispatcher queue with this.\r\n* The (Rust-side) check is on the metric and requires access to the glean object, therefore we need to re-implement it for every type\r\n\t* There might be a way of using traits here to implement it just once (we will need to \"re-implement\" exposing the common metric data though)\r\n\t* I opted for not doing that now (it's a refactoring, not blocking anything and the code duplication so far is simple)\r\n*  We also need to duplicate code on the Kotlin side, because we need a `*_should_record` function per type. Unfortunately I don't see a way to avoid this (again, duplication here contains no complex logic so for now I'm fine with it)\r\n\r\nThe biggest thing remains the first statement: Do we _need_ the check on the Kotlin side or is Rust-side only actually enough? (Dispatch enqueue cost?) \r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-21T09:27:58Z", "updated_at": "2019-05-23T11:31:31Z", "closed_at": "2019-05-22T08:29:36Z", "merged_at": "2019-05-22T08:29:36Z", "merge_commit_sha": "18c4664884421d2367c93606a795dcec25e5feed", "assignee": null, "milestone": null, "draft": 0, "head": "f49b9a5c004b5982372d838800edd61f8c71a98d", "base": "4898bd0492278f3911afde21216c8b84ce1dd5f2", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/84", "merged_by": null, "stack": null}, {"id": 280919725, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgwOTE5NzI1", "number": 85, "state": "closed", "locked": 0, "title": "Move PingType metadata to the Rust side", "user": {"value": 38294, "label": "mdboom"}, "body": "I'm just posting this here for discussion -- either here or in our next meeting if that's more efficient.  FFI and Kotlin side not implemented yet.\r\n\r\nI first considered putting the ping registry on the Glean object, since it sort of logically makes sense there.  However, libraries need to register pings at any time during startup, including before `Glean::initialize` is called.  Since we've tied `new` and `initialize` together, we couldn't add pings to the ping registry before the Glean singleton is initialized, since before that there is no Rust-side Glean object.  An alternative to make that work would be to split `new` and `initialize` apart again, which isn't great.\r\n\r\nSo I came up with this solution which uses an actual global object and state on the Rust side.  It's not bad, but it does mean for testing that there is state carried over between tests.\r\n\r\nTl;dr: I thought this could use more feedback / brainstorming before filling out the rest of the pieces.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [x] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-21T19:36:27Z", "updated_at": "2020-04-14T19:09:34Z", "closed_at": "2019-05-28T22:02:16Z", "merged_at": "2019-05-28T22:02:16Z", "merge_commit_sha": "dbcd3110388e977c06768a880e6ac06e62e2fa9f", "assignee": null, "milestone": null, "draft": 0, "head": "64a40f65c18f3eee5b2d1cdc51f35abc41d6cf2a", "base": "085207a02764f7a28a52652094ad38834803b6dc", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/85", "merged_by": null, "stack": null}, {"id": 281103540, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxMTAzNTQw", "number": 86, "state": "closed", "locked": 0, "title": "Refactored should record", "user": {"value": 2129, "label": "badboy"}, "body": "Bikeshed:\r\n\r\nShould we call the trait `MetricType` or something else?\r\n\r\nright now it only exposes the `meta()` method and the `should_record` method, but maybe we have more in the future?", "created_at": "2019-05-22T09:18:19Z", "updated_at": "2019-05-23T11:30:32Z", "closed_at": "2019-05-23T11:30:27Z", "merged_at": "2019-05-23T11:30:27Z", "merge_commit_sha": "eee01c97b4d69faffd553ededf9c718f99cc492d", "assignee": null, "milestone": null, "draft": 0, "head": "bd7f5217b30a64485a700554a8a5b7b9f562f64a", "base": "18c4664884421d2367c93606a795dcec25e5feed", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/86", "merged_by": null, "stack": null}, {"id": 281112206, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxMTEyMjA2", "number": 87, "state": "closed", "locked": 0, "title": "Refactor tests", "user": {"value": 2129, "label": "badboy"}, "body": "I tried to keep a better organization of our Rust tests.\r\nI also moved away from ugly `String.contains` tests towards our existing test API or checking the JSON directly.\r\n\r\nStringList and UUID are only half-implemented so I didn't touch the tests.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-22T09:40:44Z", "updated_at": "2019-05-23T13:41:30Z", "closed_at": "2019-05-23T13:41:28Z", "merged_at": "2019-05-23T13:41:28Z", "merge_commit_sha": "bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971", "assignee": null, "milestone": null, "draft": 0, "head": "ec438b0022423abd356ca374cc426c670de83ac7", "base": "18c4664884421d2367c93606a795dcec25e5feed", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/87", "merged_by": null, "stack": null}, {"id": 281177672, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxMTc3Njcy", "number": 88, "state": "closed", "locked": 0, "title": "1553195 labeled metrics stub", "user": {"value": 2129, "label": "badboy"}, "body": "First try at the labeled metrics.\r\nMakes use of the trait implementation in #86 (needs rebase when that gets merged).\r\n\r\nNotably lacking: Any Kotlin-side handling.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-22T12:46:22Z", "updated_at": "2019-05-23T16:00:14Z", "closed_at": "2019-05-23T16:00:09Z", "merged_at": "2019-05-23T16:00:09Z", "merge_commit_sha": "bc0ff75ab707637b437328216db03bc4f0774126", "assignee": null, "milestone": null, "draft": 0, "head": "d51b69e438fbdf6e83e67e41aad069fb00da6d6a", "base": "bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/88", "merged_by": null, "stack": null}, {"id": 281637129, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxNjM3MTI5", "number": 89, "state": "closed", "locked": 0, "title": "Import GleanTest.kt from glean-ac", "user": {"value": 883721, "label": "Dexterp37"}, "body": "Import the tests over from [this version GleanTest.kt](https://raw.githubusercontent.com/mozilla-mobile/android-components/8ef0d4b3247255ca6c456e9b5ab61338bc109209/components/service/glean/src/test/java/mozilla/components/service/glean/GleanTest.kt) from glean-ac.\r\n\r\n**Note**: the first commit simply overwrites the current test file we own.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-23T14:22:33Z", "updated_at": "2019-05-24T08:31:34Z", "closed_at": "2019-05-24T08:31:34Z", "merged_at": "2019-05-24T08:31:34Z", "merge_commit_sha": "05a11cd78e49c909b916dd4ccbb787b63787ffa9", "assignee": null, "milestone": null, "draft": 0, "head": "8efb4090d913572fbcf98273d7c983e9893ad5fa", "base": "bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/89", "merged_by": null, "stack": null}, {"id": 281657716, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxNjU3NzE2", "number": 90, "state": "closed", "locked": 0, "title": "Bug 1553424 - Fix C example (was: log on invalid handles, but don't crash)", "user": {"value": 2129, "label": "badboy"}, "body": "We never return an error and we certainly don't expect too many.\r\nYet we should log them _when we_ encounter them.\r\n\r\nIn debug mode we crash, in release we don't (that's what `debug_assert` is).\r\nNow for the handle thing, do we want to avoid crashing even in debug mode when we get an invalid one? \r\nIt certainly points to an error which we might want to see in debug (and the thing that made us aware, calling `set_upload_enabled` before init will get fixed in another way anyway).\r\n\r\nPlus, so far we initialize logging during init, saving us a check at other points, but this means our `invalid handle used` log might actually get lost when it happens before the init.\r\n\r\nwdyt?\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-23T15:05:58Z", "updated_at": "2019-05-24T13:27:22Z", "closed_at": "2019-05-24T13:27:19Z", "merged_at": "2019-05-24T13:27:18Z", "merge_commit_sha": "9bec98a76de15152d27b6fa6b26a76ba369ff173", "assignee": null, "milestone": null, "draft": 0, "head": "f83385646b913d5c1e65be3e483b5efe6a0f7078", "base": "05a11cd78e49c909b916dd4ccbb787b63787ffa9", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/90", "merged_by": null, "stack": null}, {"id": 281660607, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxNjYwNjA3", "number": 91, "state": "closed", "locked": 0, "title": "Split linting into multiple tasks", "user": {"value": 2129, "label": "badboy"}, "body": "This allows to only run clippy, which is much faster than its Kotlin\r\ncounterpart.\r\n\r\n", "created_at": "2019-05-23T15:12:15Z", "updated_at": "2019-05-23T15:58:45Z", "closed_at": "2019-05-23T15:58:41Z", "merged_at": "2019-05-23T15:58:41Z", "merge_commit_sha": "40c6a9d3c6a5072eb3440c26b72f501871d3365e", "assignee": null, "milestone": null, "draft": 0, "head": "fae6d3b1f5bde8d349af36ec556fe10a1e7b4c8c", "base": "bc70a4223b1d5f17f7f3c0e58e1545f7adcaa971", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/91", "merged_by": null, "stack": null}, {"id": 281948442, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxOTQ4NDQy", "number": 92, "state": "closed", "locked": 0, "title": "Enable logging at load time", "user": {"value": 2129, "label": "badboy"}, "body": "Based on #90, will rebase when that is merged.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-24T09:57:56Z", "updated_at": "2019-05-27T09:29:43Z", "closed_at": "2019-05-27T09:29:39Z", "merged_at": "2019-05-27T09:29:39Z", "merge_commit_sha": "aac86901a48dde3b183095aac60eb49901a161fb", "assignee": null, "milestone": null, "draft": 0, "head": "52ded22ebaa896203d6ae4eb61edab0be763da92", "base": "9bec98a76de15152d27b6fa6b26a76ba369ff173", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/92", "merged_by": null, "stack": null}, {"id": 281954392, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgxOTU0Mzky", "number": 93, "state": "closed", "locked": 0, "title": "Bug 1553424 - Setting uploadEnabled before initialization should not crash", "user": {"value": 2129, "label": "badboy"}, "body": "Follow up to #90 in which we now keep track of the flag before we initialize.\r\n\r\nWe can eventually deprecate the \"call before init\" way and move the flag into the initializer.\r\nFor now this is the easy way out of crashing.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-24T10:14:54Z", "updated_at": "2019-05-27T14:49:33Z", "closed_at": "2019-05-27T14:49:29Z", "merged_at": "2019-05-27T14:49:29Z", "merge_commit_sha": "207ba03d1a6f053a9be9bbfe441a14c196685d58", "assignee": null, "milestone": null, "draft": 0, "head": "e5efa7d96c6692860c6ed525c03db7f27ae66945", "base": "aac86901a48dde3b183095aac60eb49901a161fb", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/93", "merged_by": null, "stack": null}, {"id": 282536620, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyNTM2NjIw", "number": 94, "state": "closed", "locked": 0, "title": "Stub out the TimingDistributionMetricType", "user": {"value": 883721, "label": "Dexterp37"}, "body": "Just copying over files and commenting out things. There's no change to the files other than comments and the package name.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-27T14:31:26Z", "updated_at": "2019-05-27T14:58:13Z", "closed_at": "2019-05-27T14:58:13Z", "merged_at": "2019-05-27T14:58:13Z", "merge_commit_sha": "cc8ddcf9f24045461e0a175ef4c26feab116cac1", "assignee": null, "milestone": null, "draft": 0, "head": "796a2b4083e693705655c912ce7769b1b2202411", "base": "aac86901a48dde3b183095aac60eb49901a161fb", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/94", "merged_by": null, "stack": null}, {"id": 282735380, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyNzM1Mzgw", "number": 95, "state": "closed", "locked": 0, "title": "Bug 1552873 - Implement labeled metrics", "user": {"value": 2129, "label": "badboy"}, "body": "A first try of implementing a (good enough) solution for the labeled metrics.\r\n\r\nI want to write a few more comments before I make this a full PR.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [x] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T09:08:55Z", "updated_at": "2019-05-30T13:51:01Z", "closed_at": "2019-05-29T08:34:52Z", "merged_at": "2019-05-29T08:34:52Z", "merge_commit_sha": "bb69612ff31eb00dbd92f66378ffa2f7e616066a", "assignee": null, "milestone": null, "draft": 0, "head": "94f87592053b5a113bc005052d6420b98ba727d9", "base": "dbcd3110388e977c06768a880e6ac06e62e2fa9f", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/95", "merged_by": null, "stack": null}, {"id": 282749734, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyNzQ5NzM0", "number": 96, "state": "closed", "locked": 0, "title": "`should_record` fixup", "user": {"value": 883721, "label": "Dexterp37"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T09:45:18Z", "updated_at": "2019-05-28T09:52:17Z", "closed_at": "2019-05-28T09:52:17Z", "merged_at": "2019-05-28T09:52:17Z", "merge_commit_sha": "b4c0e8fafaec7a82c6cc45b6480a3650f3f994af", "assignee": null, "milestone": null, "draft": 0, "head": "9806e8e7dbf32d13082f5846485973e1c1fb487e", "base": "cc8ddcf9f24045461e0a175ef4c26feab116cac1", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/96", "merged_by": null, "stack": null}, {"id": 282759477, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyNzU5NDc3", "number": 97, "state": "closed", "locked": 0, "title": "Add how to publish new metric types in the module", "user": {"value": 883721, "label": "Dexterp37"}, "body": "Add the missing steps for properly exposing a new metric type. Without these steps, build will fail.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T10:09:32Z", "updated_at": "2019-07-10T16:33:24Z", "closed_at": "2019-05-28T12:21:50Z", "merged_at": "2019-05-28T12:21:50Z", "merge_commit_sha": "085207a02764f7a28a52652094ad38834803b6dc", "assignee": null, "milestone": null, "draft": 0, "head": "04bd2b0341975044cc440bf77aa49d10ee0c8da4", "base": "b4c0e8fafaec7a82c6cc45b6480a3650f3f994af", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/97", "merged_by": null, "stack": null}, {"id": 282791058, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyNzkxMDU4", "number": 98, "state": "closed", "locked": 0, "title": "Snapshot a single metric", "user": {"value": 2129, "label": "badboy"}, "body": "This avoids going awkwardly through a JSON-serialized storage and trying to find the right place.\r\n\r\nExtracted from #95 \r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T11:39:58Z", "updated_at": "2019-05-28T15:07:21Z", "closed_at": "2019-05-28T15:07:18Z", "merged_at": "2019-05-28T15:07:18Z", "merge_commit_sha": "a4dff9bfa190f24a4a01e62f0acbfc05207da0b5", "assignee": null, "milestone": null, "draft": 0, "head": "e6dfdc225401f2eab09a56c52b166db645c362bc", "base": "b4c0e8fafaec7a82c6cc45b6480a3650f3f994af", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/98", "merged_by": null, "stack": null}, {"id": 282880421, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyODgwNDIx", "number": 99, "state": "closed", "locked": 0, "title": "Add error reporting for labeled metrics (and counters)", "user": {"value": 2129, "label": "badboy"}, "body": "Based on #95, needs a rebase when that lands.\r\n\r\nThe last 3 commits are relevant. We now have all things in place for error reporting using labeled metrics.\r\nEven though the error reporting itself doesn't use the labeled metrics, we simply depend on the same \"encoding\" of labels into the key.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T15:19:42Z", "updated_at": "2019-06-05T08:24:37Z", "closed_at": "2019-06-05T08:10:12Z", "merged_at": "2019-06-05T08:10:12Z", "merge_commit_sha": "efdcd37604b4a6244478f406f5d5d9ad80604eff", "assignee": null, "milestone": null, "draft": 0, "head": "55274abdeb48d0b7390b58efda5ceef7e53db30d", "base": "b9379f2d8036fd22021b1df1666087918898e84f", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/99", "merged_by": null, "stack": null}, {"id": 282903782, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyOTAzNzgy", "number": 100, "state": "closed", "locked": 0, "title": "Bug 1555031 - Generate kotlin docs", "user": {"value": 2129, "label": "badboy"}, "body": "With this `./gradlew docs` will generate HTML documentation in build/javadoc/glean.rs/\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T16:17:28Z", "updated_at": "2019-05-29T13:35:27Z", "closed_at": "2019-05-29T13:35:13Z", "merged_at": "2019-05-29T13:35:13Z", "merge_commit_sha": "f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132", "assignee": null, "milestone": null, "draft": 0, "head": "dc88c0d3ded1d7274ec33cf622f8723ca305294d", "base": "bb69612ff31eb00dbd92f66378ffa2f7e616066a", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/100", "merged_by": null, "stack": null}, {"id": 282981219, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgyOTgxMjE5", "number": 101, "state": "closed", "locked": 0, "title": "Add Kotlin docs to CI", "user": {"value": 38294, "label": "mdboom"}, "body": "This is an experimental follow-on to link to the Kotlin docs from the mdbook content and then run on CI and deploy all together.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-28T20:18:24Z", "updated_at": "2019-05-30T14:49:06Z", "closed_at": "2019-05-30T14:49:06Z", "merged_at": "2019-05-30T14:49:06Z", "merge_commit_sha": "b5c24899bd92c377780e82d2ddbf3c6af99a778c", "assignee": null, "milestone": null, "draft": 0, "head": "9aa39f80e952810bb3857ec939c87878ceb758d2", "base": "93736f8598b607f77c96bf9cda266c7716dde987", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/101", "merged_by": null, "stack": null}, {"id": 283153204, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMTUzMjA0", "number": 102, "state": "closed", "locked": 0, "title": "Implement the DatetimeMetricType", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This implements the full stack for the `datetime` metric: from the Rust implementation to the Kotlin platform specific code.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T08:43:34Z", "updated_at": "2019-06-04T12:35:47Z", "closed_at": "2019-06-04T09:56:53Z", "merged_at": "2019-06-04T09:56:53Z", "merge_commit_sha": "c96af194a24759b741148b4b179e6d9b30e2b63a", "assignee": null, "milestone": null, "draft": 0, "head": "f4cd00d5bb5df52abe7caa8252bee78408d9c22d", "base": "232eab55e97d01bb6df8cc242192a1b232392486", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/102", "merged_by": null, "stack": null}, {"id": 283266277, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMjY2Mjc3", "number": 103, "state": "closed", "locked": 0, "title": "Remove unused dependencies", "user": {"value": 2129, "label": "badboy"}, "body": "These are currently not used anywhere and can be removed.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T13:40:03Z", "updated_at": "2019-05-29T15:40:15Z", "closed_at": "2019-05-29T15:40:11Z", "merged_at": "2019-05-29T15:40:11Z", "merge_commit_sha": "93736f8598b607f77c96bf9cda266c7716dde987", "assignee": null, "milestone": null, "draft": 0, "head": "0b50b10d362dccf47c8d961e0f02a987aa457d6f", "base": "f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/103", "merged_by": null, "stack": null}, {"id": 283268131, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMjY4MTMx", "number": 104, "state": "closed", "locked": 0, "title": "Fetch seen labels from the database", "user": {"value": 2129, "label": "badboy"}, "body": "This goes through the database and looks for all stored data for the\r\nnamed labeled metric and extracts the labels.\r\n\r\nI thought about extracting the extraction part into a function but couldn't come up with a proper name for it.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T13:44:09Z", "updated_at": "2019-06-04T11:32:13Z", "closed_at": "2019-06-04T11:31:34Z", "merged_at": "2019-06-04T11:31:34Z", "merge_commit_sha": "af8db2f1257014044eecd8c8381fadd4244afecc", "assignee": null, "milestone": null, "draft": 0, "head": "4e0ba1686815005bb16ea2299c89de871b5df5ec", "base": "c96af194a24759b741148b4b179e6d9b30e2b63a", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/104", "merged_by": null, "stack": null}, {"id": 283272868, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMjcyODY4", "number": 105, "state": "closed", "locked": 0, "title": "Add codeowners", "user": {"value": 2129, "label": "badboy"}, "body": "It's simple: for now it's all 3 of us for everything.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T13:54:36Z", "updated_at": "2019-05-29T14:30:28Z", "closed_at": "2019-05-29T14:30:26Z", "merged_at": "2019-05-29T14:30:26Z", "merge_commit_sha": "2082ac2e90cec289e72a83a5d28b8d382a190c5b", "assignee": null, "milestone": null, "draft": 0, "head": "294078710aa64b463dcdf922b3842c5725c21b22", "base": "f63d87a9ebe74ce4b193cb35a6ca2dd40ed6f132", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/105", "merged_by": null, "stack": null}, {"id": 283287134, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMjg3MTM0", "number": 106, "state": "closed", "locked": 0, "title": "Reinstate deep JSON inspection of labeled metric tests", "user": {"value": 38294, "label": "mdboom"}, "body": "This brings back in some testing content from glean-ac in LabeledMetricTypeTests.kt.\r\n\r\nMainly, this checks pings against the schema, since getting that right for labeled metrics is a bit fiddly.\r\n\r\nIn order to do this, it makes `collectAndCheckPingSchema` from glean-ac work and updates the API to use `PingType` rather than ping names.\r\n\r\nThis had knockon effects in the FFI, and then the C FFI example, so that's been updated to run on Linux and also run in CI.  **I plan to go back and make that work on Mac as well again, once I've verified CI is working on that.**\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T14:25:12Z", "updated_at": "2020-04-14T19:09:27Z", "closed_at": "2019-05-29T15:37:36Z", "merged_at": "2019-05-29T15:37:36Z", "merge_commit_sha": "6673bdfd6d5cca9d58f1fc34caedf65f6e4c7f61", "assignee": null, "milestone": null, "draft": 0, "head": "374404375c3898ca1e3f72e4f5d5f50b09254710", "base": "2082ac2e90cec289e72a83a5d28b8d382a190c5b", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/106", "merged_by": null, "stack": null}, {"id": 283383114, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzMzgzMTE0", "number": 107, "state": "closed", "locked": 0, "title": "1554275: Port PingMakerTests.kt to the rust side", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-29T18:36:54Z", "updated_at": "2020-04-14T19:09:34Z", "closed_at": "2019-06-03T20:08:21Z", "merged_at": "2019-06-03T20:08:21Z", "merge_commit_sha": "7470f7edba3daffea637d5084d134d09c26a3ba9", "assignee": null, "milestone": null, "draft": 0, "head": "c0dd522cd6f290317f5f306094e6941c2f6f0bc8", "base": "c7841592feee355ad04b4f569ec931ab7ad789ec", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/107", "merged_by": null, "stack": null}, {"id": 283699423, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzNjk5NDIz", "number": 108, "state": "closed", "locked": 0, "title": "Fix Kotlin doc deployment", "user": {"value": 38294, "label": "mdboom"}, "body": "Persisting the docs in two different tasks and then merging for deployment didn't work as I had hoped, so I'm trying something different.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-30T15:26:42Z", "updated_at": "2020-04-14T19:09:25Z", "closed_at": "2019-05-30T16:19:32Z", "merged_at": "2019-05-30T16:19:32Z", "merge_commit_sha": "98cadefe621fe2f9cc51ee517718a2e5b7fa792f", "assignee": null, "milestone": null, "draft": 0, "head": "eed9e2198ecb7ab4da0a71cf0c6ccf06961b3556", "base": "b5c24899bd92c377780e82d2ddbf3c6af99a778c", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/108", "merged_by": null, "stack": null}, {"id": 283727434, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzNzI3NDM0", "number": 109, "state": "closed", "locked": 0, "title": "Revert \"Fix Kotlin doc deployment\"", "user": {"value": 38294, "label": "mdboom"}, "body": "Reverts mozilla/glean#108", "created_at": "2019-05-30T16:45:19Z", "updated_at": "2019-07-10T16:33:04Z", "closed_at": "2019-05-30T16:45:30Z", "merged_at": "2019-05-30T16:45:30Z", "merge_commit_sha": "20170b48207af3f26d5dc8a1df858b5f1d67ca20", "assignee": null, "milestone": null, "draft": 0, "head": "06f00b58f53eed88ebbac59c76f5fb83ca8f7e0c", "base": "98cadefe621fe2f9cc51ee517718a2e5b7fa792f", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/109", "merged_by": null, "stack": null}, {"id": 283743977, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzNzQzOTc3", "number": 110, "state": "closed", "locked": 0, "title": "Fix Kotlin doc deploy", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-30T17:34:38Z", "updated_at": "2019-05-30T18:35:27Z", "closed_at": "2019-05-30T18:35:26Z", "merged_at": "2019-05-30T18:35:26Z", "merge_commit_sha": "ad30c9f7f2832e8a466bc59414706c8721f1be0c", "assignee": null, "milestone": null, "draft": 0, "head": "dab371d30c2a58c36f3fbdf917fd20960e3c3eba", "base": "20170b48207af3f26d5dc8a1df858b5f1d67ca20", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/110", "merged_by": null, "stack": null}, {"id": 283767053, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzNzY3MDUz", "number": 111, "state": "closed", "locked": 0, "title": "Hardcode project name in Kotlin doc generation", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-30T18:43:40Z", "updated_at": "2020-04-14T19:09:16Z", "closed_at": "2019-05-30T18:43:53Z", "merged_at": "2019-05-30T18:43:53Z", "merge_commit_sha": "b3c4fb9540bb08096516b98498165cf2216ab73f", "assignee": null, "milestone": null, "draft": 0, "head": "71748cc76a9a6243d9b262ee102ca8c6e4fdb400", "base": "ad30c9f7f2832e8a466bc59414706c8721f1be0c", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/111", "merged_by": null, "stack": null}, {"id": 283944943, "node_id": "MDExOlB1bGxSZXF1ZXN0MjgzOTQ0OTQz", "number": 112, "state": "closed", "locked": 0, "title": "Upgrade the WorkManager dependency to 2.0.1", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This fixes a crash occurring in glean when the connectivity is disabled and then enabled. See\r\nhttps://github.com/mozilla-mobile/android-components/issues/3110 for context.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-31T08:16:47Z", "updated_at": "2019-05-31T13:03:49Z", "closed_at": "2019-05-31T13:03:48Z", "merged_at": "2019-05-31T13:03:48Z", "merge_commit_sha": "c7841592feee355ad04b4f569ec931ab7ad789ec", "assignee": {"value": 883721, "label": "Dexterp37"}, "milestone": null, "draft": 0, "head": "30eab65768827ab481f63bc0acb8ae91fb7ec807", "base": "b3c4fb9540bb08096516b98498165cf2216ab73f", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/112", "merged_by": null, "stack": null}, {"id": 284101851, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjg0MTAxODUx", "number": 113, "state": "closed", "locked": 0, "title": "1555975: Move markdown docs from glean-ac to glean-core", "user": {"value": 38294, "label": "mdboom"}, "body": "This moves all of the doc content in glean-ac in markdown (i.e. not docstrings) over to glean-core -- specifically, this is everything in `components/service/glean/docs` as well as `components/service/glean/README.md`, but reorganized into smaller chunks.  I tried to update things that have changed, but not much has since we're keeping the same public API.\r\n\r\nFor the documentation of the specific metric types, I tried to split the difference between the \"narrative\" style in glean-ac and the systematic style with standard headers that @badboy started over here.  I basically added a `Configuration` section (talking about metrics.yaml content), an `API` section talking about using the metric and a `Reference` section linking to the javadoc.\r\n\r\nIt's clear from this that eventually we'll need a way to handle documenting Kotlin, Swift, Rust and beyond -- maybe [something like this](https://json-schema.org/understanding-json-schema/conventions.html#language-specific-notes) -- but for now, this is all completely Kotlin/Android-specific.\r\n\r\nThis adds a linkchecking step to CI -- I found it really helpful as I was moving pieces around from other repos to automate the process of making sure internal links go somewhere.  I considered using [mdbook-linkcheck](https://github.com/Michael-F-Bryan/mdbook-linkcheck) for this, but that doesn't deal with the fact that we have docs generated from 3 sources: mdbook, rustdoc and dokka.  Instead, I'm using the pretty old and slow but popular \"linkchecker\" tool, mainly just because it has a Debian package.  **NOTE**: This is only checking internal links.  Checking external links is much slower, and there's a lot of false positives to things in the generated docs that we can't control.\r\n\r\nThis also had me looking at the Kotlin docs and noting that some things should be private but aren't.  Sorry if that's kind of out-of-scope -- happy to separate that out to another PR.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-05-31T15:52:41Z", "updated_at": "2020-04-14T19:09:31Z", "closed_at": "2019-06-05T12:02:13Z", "merged_at": "2019-06-05T12:02:13Z", "merge_commit_sha": "25b97d6ccfc8107a743d687363f3a2a301cd28ed", "assignee": null, "milestone": null, "draft": 0, "head": "975e2a14322fea83bc0060f38735cc02614a3b3a", "base": "b9379f2d8036fd22021b1df1666087918898e84f", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/113", "merged_by": null, "stack": null}, {"id": 284601285, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjg0NjAxMjg1", "number": 114, "state": "closed", "locked": 0, "title": "Store an instance of the underlying metric and clone it on request", "user": {"value": 2129, "label": "badboy"}, "body": "This has the overhead of storing a metric instance per labeled metric.\r\nHowever, these should be rather small.\r\n\r\nAnd on the upside this allows us to store metric-type-specific data\r\n(e.g. the time unit for DateTime) for that metric only instead of inside\r\nthe common metric data.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-06-03T14:53:05Z", "updated_at": "2019-06-04T10:22:04Z", "closed_at": "2019-06-04T08:27:04Z", "merged_at": "2019-06-04T08:27:04Z", "merge_commit_sha": "232eab55e97d01bb6df8cc242192a1b232392486", "assignee": null, "milestone": null, "draft": 0, "head": "c1c51aa5e590b35b873c00b388de13fcd1bc29ba", "base": "c7841592feee355ad04b4f569ec931ab7ad789ec", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/114", "merged_by": null, "stack": null}, {"id": 284717680, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjg0NzE3Njgw", "number": 115, "state": "closed", "locked": 0, "title": "Small copypasta fix to contribution docs.", "user": {"value": 1123376, "label": "chutten"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-06-03T20:26:24Z", "updated_at": "2019-06-03T20:35:11Z", "closed_at": "2019-06-03T20:35:11Z", "merged_at": "2019-06-03T20:35:11Z", "merge_commit_sha": "96cef895fa0945c1583792f4b7307311abe22291", "assignee": null, "milestone": null, "draft": 0, "head": "acd4de608712e934e942e01dc12a079a1af21012", "base": "7470f7edba3daffea637d5084d134d09c26a3ba9", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/115", "merged_by": null, "stack": null}, {"id": 284902490, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjg0OTAyNDkw", "number": 116, "state": "closed", "locked": 0, "title": "Bump the string length limit to 100 characters to match glean-ac", "user": {"value": 883721, "label": "Dexterp37"}, "body": "This is about to land in glean-ac too. Let's not merge it until mozilla-mobile/android-components#3236 is merged.\r\n\r\n### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-06-04T10:06:29Z", "updated_at": "2019-06-04T12:40:58Z", "closed_at": "2019-06-04T12:40:58Z", "merged_at": "2019-06-04T12:40:58Z", "merge_commit_sha": "b9379f2d8036fd22021b1df1666087918898e84f", "assignee": null, "milestone": null, "draft": 0, "head": "a2118c49f61bce0af7bc1849e11685c8e28bd039", "base": "c96af194a24759b741148b4b179e6d9b30e2b63a", "author_association": "MEMBER", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/116", "merged_by": null, "stack": null}, {"id": 285096042, "node_id": "MDExOlB1bGxSZXF1ZXN0Mjg1MDk2MDQy", "number": 117, "state": "closed", "locked": 0, "title": "1552842: Document how to run tests", "user": {"value": 38294, "label": "mdboom"}, "body": "### Pull Request checklist ###\r\n<!-- Before submitting the PR, please address each item -->\r\n- [ ] **Quality**: This PR builds and tests run cleanly\r\n  - `make test` runs without emitting any warnings\r\n  - `make lint` runs without emitting any errors\r\n- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not\r\n- [ ] **Changelog**: This PR includes a changelog entry or an explanation of why it does not need one\r\n  - Any breaking changes to language binding APIs are noted explicitly\r\n", "created_at": "2019-06-04T18:41:32Z", "updated_at": "2020-04-14T19:09:09Z", "closed_at": "2019-06-05T13:36:53Z", "merged_at": "2019-06-05T13:36:53Z", "merge_commit_sha": "57c6e83d6d0ace2e0bfd2bb6f6d9662222b45152", "assignee": null, "milestone": null, "draft": 0, "head": "23ce9c0633ee23a6ae85b23b65c5e2400b2d059a", "base": "25b97d6ccfc8107a743d687363f3a2a301cd28ed", "author_association": "CONTRIBUTOR", "auto_merge": null, "repo": {"value": 160544457, "label": "glean"}, "url": "https://github.com/mozilla/glean/pull/117", "merged_by": null, "stack": null}], "truncated": false, "filtered_table_rows_count": 3625, "expanded_columns": ["merged_by", "repo", "milestone", "assignee", "user"], "expandable_columns": [[{"column": "merged_by", "other_table": "users", "other_column": "id"}, "name"], [{"column": "repo", "other_table": "repos", "other_column": "id"}, "name"], [{"column": "milestone", "other_table": "milestones", "other_column": "id"}, "title"], [{"column": "assignee", "other_table": "users", "other_column": "id"}, "name"], [{"column": "user", "other_table": "users", "other_column": "id"}, "name"]], "columns": ["id", "node_id", "number", "state", "locked", "title", "user", "body", "created_at", "updated_at", "closed_at", "merged_at", "merge_commit_sha", "assignee", "milestone", "draft", "head", "base", "author_association", "auto_merge", "repo", "url", "merged_by", "stack"], "primary_keys": ["id"], "units": {}, "query": {"sql": "select id, node_id, number, state, locked, title, user, body, created_at, updated_at, closed_at, merged_at, merge_commit_sha, assignee, milestone, draft, head, base, author_association, auto_merge, repo, url, merged_by, stack from pull_requests order by id limit 101", "params": {}}, "facet_results": {}, "suggested_facets": [{"name": "state", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=state"}, {"name": "locked", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=locked"}, {"name": "assignee", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=assignee"}, {"name": "milestone", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=milestone"}, {"name": "draft", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=draft"}, {"name": "author_association", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet=author_association"}, {"name": "created_at", "type": "date", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet_date=created_at"}, {"name": "updated_at", "type": "date", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet_date=updated_at"}, {"name": "closed_at", "type": "date", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet_date=closed_at"}, {"name": "merged_at", "type": "date", "toggle_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_facet_date=merged_at"}], "next": "285096042", "next_url": "https://data.fnordig.de/github/pull_requests.json?_labels=on&_next=285096042", "private": false, "allow_execute_sql": true, "query_ms": 204.40049469470978}